[fasta] Add and correct offsets on nodes

pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Note: copied from package:kernel at revision 7346348.
 
 /// A library to help transform compounds and null-aware accessors into
 /// let expressions.
 library kernel.frontend.accessors;
 
@@ skipping 99 matching lines @@
 
   /// Returns an [Expression] representing a compile-time error wrapping
   /// [value].
   ///
   /// At runtime, [value] will be evaluated before throwing an exception.
   makeInvalidWrite(Expression value) => wrapInvalid(value);
 }
 
 class VariableAccessor extends Accessor {
   VariableDeclaration variable;
+  int charOffset;
   DartType promotedType;
 
   VariableAccessor(this.variable, [this.promotedType]);
 
-  VariableAccessor.internal(this.variable, this.promotedType);
+  VariableAccessor.internal(this.variable, this.charOffset, this.promotedType);
 
-  _makeRead() => new VariableGet(variable, promotedType);
+  _makeRead() => new VariableGet(variable, promotedType)..fileOffset = charOffset;

[ahe, 2017/03/08 12:31:49]

Long line.

 
   _makeWrite(Expression value, bool voidContext) {
     return variable.isFinal || variable.isConst
         ? makeInvalidWrite(value)
-        : new VariableSet(variable, value);
+        : new VariableSet(variable, value)..fileOffset = charOffset;
   }
 }
 
 class PropertyAccessor extends Accessor {
   VariableDeclaration _receiverVariable;
   Expression receiver;
   Name name;
   Member getter, setter;
+  int charOffset;
 
-  static Accessor make(
-      Expression receiver, Name name, Member getter, Member setter) {
+  static Accessor make(Expression receiver, Name name, Member getter,
+      Member setter, int charOffset) {
     if (receiver is ThisExpression) {
       return new ThisPropertyAccessor(name, getter, setter);
     } else {
-      return new PropertyAccessor.internal(receiver, name, getter, setter);
+      return new PropertyAccessor.internal(
+          receiver, name, getter, setter, charOffset);
     }
   }
 
-  PropertyAccessor.internal(this.receiver, this.name, this.getter, this.setter);
+  PropertyAccessor.internal(
+      this.receiver, this.name, this.getter, this.setter, this.charOffset);
 
-  _makeSimpleRead() => new PropertyGet(receiver, name, getter);
+  _makeSimpleRead() =>
+      new PropertyGet(receiver, name, getter)..fileOffset = charOffset;
   _makeSimpleWrite(Expression value, bool voidContext) {
-    return new PropertySet(receiver, name, value, setter);
+    return new PropertySet(receiver, name, value, setter)
+      ..fileOffset = charOffset;
   }
 
   receiverAccess() {
     _receiverVariable ??= new VariableDeclaration.forValue(receiver);
-    return new VariableGet(_receiverVariable);
+    return new VariableGet(_receiverVariable)..fileOffset = charOffset;
   }
 
-  _makeRead() => new PropertyGet(receiverAccess(), name, getter);
+  _makeRead() =>
+      new PropertyGet(receiverAccess(), name, getter)..fileOffset = charOffset;
 
   _makeWrite(Expression value, bool voidContext) {
-    return new PropertySet(receiverAccess(), name, value, setter);
+    return new PropertySet(receiverAccess(), name, value, setter)
+      ..fileOffset = charOffset;
   }
 
   _finish(Expression body) => makeLet(_receiverVariable, body);
 }
 
 /// Special case of [PropertyAccessor] to avoid creating an indirect access to
 /// 'this'.
 class ThisPropertyAccessor extends Accessor {
   Name name;
   Member getter, setter;
@@ skipping 277 matching lines @@
 
 VariableDeclaration makeOrReuseVariable(Expression value) {
   // TODO: Devise a way to remember if a variable declaration was reused
   // or is fresh (hence needs a let binding).
   return new VariableDeclaration.forValue(value);
 }
 
 Expression wrapInvalid(Expression e) {
   return new Let(new VariableDeclaration.forValue(e), new InvalidExpression());
 }