Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

Issue 2736093003: [fasta] Add and correct offsets on nodes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
index ce7484c74ec4c9b891c82704a232311a254cad97..c54a7e32e19fa868112e712cf7564c4458dac6da 100644
--- a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
@@ -117,18 +117,19 @@ abstract class Accessor {
class VariableAccessor extends Accessor {
VariableDeclaration variable;
+ int charOffset;
DartType promotedType;
VariableAccessor(this.variable, [this.promotedType]);
- VariableAccessor.internal(this.variable, this.promotedType);
+ VariableAccessor.internal(this.variable, this.charOffset, this.promotedType);
- _makeRead() => new VariableGet(variable, promotedType);
+ _makeRead() => new VariableGet(variable, promotedType)..fileOffset = charOffset;
ahe 2017/03/08 12:31:49 Long line.
_makeWrite(Expression value, bool voidContext) {
return variable.isFinal || variable.isConst
? makeInvalidWrite(value)
- : new VariableSet(variable, value);
+ : new VariableSet(variable, value)..fileOffset = charOffset;
}
}
@@ -137,32 +138,39 @@ class PropertyAccessor extends Accessor {
Expression receiver;
Name name;
Member getter, setter;
+ int charOffset;
- static Accessor make(
- Expression receiver, Name name, Member getter, Member setter) {
+ static Accessor make(Expression receiver, Name name, Member getter,
+ Member setter, int charOffset) {
if (receiver is ThisExpression) {
return new ThisPropertyAccessor(name, getter, setter);
} else {
- return new PropertyAccessor.internal(receiver, name, getter, setter);
+ return new PropertyAccessor.internal(
+ receiver, name, getter, setter, charOffset);
}
}
- PropertyAccessor.internal(this.receiver, this.name, this.getter, this.setter);
+ PropertyAccessor.internal(
+ this.receiver, this.name, this.getter, this.setter, this.charOffset);
- _makeSimpleRead() => new PropertyGet(receiver, name, getter);
+ _makeSimpleRead() =>
+ new PropertyGet(receiver, name, getter)..fileOffset = charOffset;
_makeSimpleWrite(Expression value, bool voidContext) {
- return new PropertySet(receiver, name, value, setter);
+ return new PropertySet(receiver, name, value, setter)
+ ..fileOffset = charOffset;
}
receiverAccess() {
_receiverVariable ??= new VariableDeclaration.forValue(receiver);
- return new VariableGet(_receiverVariable);
+ return new VariableGet(_receiverVariable)..fileOffset = charOffset;
}
- _makeRead() => new PropertyGet(receiverAccess(), name, getter);
+ _makeRead() =>
+ new PropertyGet(receiverAccess(), name, getter)..fileOffset = charOffset;
_makeWrite(Expression value, bool voidContext) {
- return new PropertySet(receiverAccess(), name, value, setter);
+ return new PropertySet(receiverAccess(), name, value, setter)
+ ..fileOffset = charOffset;
}
_finish(Expression body) => makeLet(_receiverVariable, body);
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart ('k') | pkg/front_end/lib/src/fasta/parser/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698