Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart

Issue 2736093003: [fasta] Add and correct offsets on nodes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
index e79aff2c89af444dbe818248c45a9ee2690e85fe..20c26cf9e9151c473b396b1047c4c007fbf442b1 100644
--- a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
@@ -96,10 +96,10 @@ abstract class BuilderAccessor implements Accessor {
buildPropertyAccess(IncompleteSend send, bool isNullAware) {
if (send is SendAccessor) {
return buildMethodInvocation(
- buildSimpleRead(), send.name, send.arguments, charOffset,
+ buildSimpleRead(), send.name, send.arguments, send.charOffset,
isNullAware: isNullAware);
} else {
- return PropertyAccessor.make(helper, charOffset, buildSimpleRead(),
+ return PropertyAccessor.make(helper, send.charOffset, buildSimpleRead(),
send.name, null, null, isNullAware);
}
}
@@ -519,11 +519,9 @@ class IndexAccessor extends kernel.IndexAccessor with BuilderAccessor {
class PropertyAccessor extends kernel.PropertyAccessor with BuilderAccessor {
final BuilderHelper helper;
- final int charOffset;
-
- PropertyAccessor.internal(this.helper, this.charOffset, Expression receiver,
+ PropertyAccessor.internal(this.helper, int charOffset, Expression receiver,
Name name, Member getter, Member setter)
- : super.internal(receiver, name, getter, setter);
+ : super.internal(receiver, name, getter, setter, charOffset);
String get plainNameForRead => name.name;
@@ -699,11 +697,9 @@ class NullAwarePropertyAccessor extends kernel.NullAwarePropertyAccessor
class VariableAccessor extends kernel.VariableAccessor with BuilderAccessor {
final BuilderHelper helper;
- final int charOffset;
-
- VariableAccessor(this.helper, this.charOffset, VariableDeclaration variable,
+ VariableAccessor(this.helper, int charOffset, VariableDeclaration variable,
[DartType promotedType])
- : super.internal(variable, promotedType);
+ : super.internal(variable, charOffset, promotedType);
String get plainNameForRead => variable.name;

Powered by Google App Engine
This is Rietveld 408576698