Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2735903005: gn: Stop checking for gyp-style build dirs. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Stop checking for gyp-style build dirs. gn has replaced gyp quite a while ago, so this shouldn't be needed any more, and it'll make running gn a few milliseconds faster. BUG=none Review-Url: https://codereview.chromium.org/2735903005 Cr-Commit-Position: refs/heads/master@{#455277} Committed: https://chromium.googlesource.com/chromium/src/+/a65e1c607032e3dae2d3652c54ddc8fe96b442fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M build/dotfile_settings.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
4 years ago (2017-03-07 21:54:45 UTC) #3
Dirk Pranke
lgtm, thanks :).
4 years ago (2017-03-07 21:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735903005/1
4 years ago (2017-03-07 22:01:03 UTC) #8
commit-bot: I haz the power
4 years ago (2017-03-07 23:13:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a65e1c607032e3dae2d3652c54dd...

Powered by Google App Engine
This is Rietveld 408576698