Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: build/config/BUILD.gn

Issue 2735903005: gn: Stop checking for gyp-style build dirs. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/dotfile_settings.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index b9eb2ef50aae60463036b01f372b4d93ee90eaf9..0c2b660a3649df1335bc3ebef513590fac2d1289 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -13,14 +13,6 @@ import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//build/toolchain/goma.gni")
-# One common error that happens is that GYP-generated headers within gen/ get
-# included rather than the GN-generated ones within gen/ subdirectories.
-# TODO(GYP_GONE): Remove once GYP is gone (as well as exec_script exception).
-assert(
- exec_script("//build/dir_exists.py", [ "obj.host" ], "string") == "False",
- "GYP artifacts detected in $root_build_dir.$0x0A" +
- "You must wipe this directory before building with GN.")
-
declare_args() {
# When set (the default) enables C++ iterator debugging in debug builds.
# Iterator debugging is always off in release builds (technically, this flag
« no previous file with comments | « no previous file | build/dotfile_settings.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698