Hotfix: hasText value is incorrectly set

Hotfix: hasText value is incorrectly set

Following the refactoring in CL: 2694543002 the value of hasText is incorrectly
set. To be precise, hasText is always set to the negate of its correct value.

BUG=602427
Review-Url: https://codereview.chromium.org/2735633005
Cr-Commit-Position: refs/heads/master@{#454901}
Committed: https://chromium.googlesource.com/chromium/src/+/6e3e9e553fee7cd6246ac4bd604303e5cdb3694f

[EhsanK, 2017-03-06 16:15:12]

ekaramad@chromium.org changed reviewers:
+ avi@chromium.org

[EhsanK, 2017-03-06 16:15:13]

Hello Avi,

Could you please take a quick look?

Thanks!

https://codereview.chromium.org/2735633005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://codereview.chromium.org/2735633005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:3422: BOOL hasText
= !selection || selection->selected_text().empty();
Before the refactoring we had:

BOOL hasText = !renderWidgetHostView_->selected_text().empty();

[Avi (use Gerrit), 2017-03-06 16:21:12]

lgtm

https://codereview.chromium.org/2735633005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://codereview.chromium.org/2735633005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:3422: BOOL hasText
= !selection || selection->selected_text().empty();
On 2017/03/06 16:15:13, EhsanK wrote:
> Before the refactoring we had:
> 
> BOOL hasText = !renderWidgetHostView_->selected_text().empty();
>   

Acknowledged.

[EhsanK, 2017-03-06 18:05:02]

Thanks Avi! CQ-ing soon.

[EhsanK, 2017-03-06 18:05:08]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:05:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 18:45:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488823508191940, "parent_rev":
"f12fb02e2f6affacbec98e8d147868ffbdce019f", "commit_rev":
"6e3e9e553fee7cd6246ac4bd604303e5cdb3694f"}

[commit-bot: I haz the power, 2017-03-06 18:45:53]

Description was changed from

==========
Hotfix: hasText value is incorrectly set

Following the refactoring in CL: 2694543002 the value of hasText is incorrectly
set. To be precise, hasText is always set to the negate of its correct value.

BUG=602427
==========

to

==========
Hotfix: hasText value is incorrectly set

Following the refactoring in CL: 2694543002 the value of hasText is incorrectly
set. To be precise, hasText is always set to the negate of its correct value.

BUG=602427

Review-Url: https://codereview.chromium.org/2735633005
Cr-Commit-Position: refs/heads/master@{#454901}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e3e9e553fee7cd6246ac4bd6043...
==========

[commit-bot: I haz the power, 2017-03-06 18:45:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e3e9e553fee7cd6246ac4bd6043...