content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2735633005: Hotfix: hasText value is incorrectly set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2735633005: Hotfix: hasText value is incorrectly set (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index b67a5f3d160e4521c879bcdb7bf30b7fa005876a..4bbf13f0be7f533b4700161c86e22e63c83846a8 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -3419,7 +3419,7 @@ extern NSString *NSTextInputReplacementRangeAttributeName;

BOOL returnTypeIsString = [returnType isEqual:NSStringPboardType];

const content::TextInputManager::TextSelection* selection =

renderWidgetHostView_->GetTextSelection();

- BOOL hasText = !selection || selection->selected_text().empty();

EhsanK 2017/03/06 16:15:13 Before the refactoring we had: BOOL hasText = !re

Avi (use Gerrit) 2017/03/06 16:21:12 Acknowledged.

+ BOOL hasText = selection && !selection->selected_text().empty();

BOOL takesText =

renderWidgetHostView_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE;

« no previous file with comments | « no previous file | no next file » | no next file with comments »