Hotfix: hasText value is incorrectly set

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <Carbon/Carbon.h>
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
@@ skipping 3401 matching lines @@
 
 // Overriding a NSResponder method to support application services.
 
 - (id)validRequestorForSendType:(NSString*)sendType
                      returnType:(NSString*)returnType {
   id requestor = nil;
   BOOL sendTypeIsString = [sendType isEqual:NSStringPboardType];
   BOOL returnTypeIsString = [returnType isEqual:NSStringPboardType];
   const content::TextInputManager::TextSelection* selection =
       renderWidgetHostView_->GetTextSelection();
-  BOOL hasText = !selection || selection->selected_text().empty();

[EhsanK, 2017/03/06 16:15:13]

Before the refactoring we had:

BOOL hasText = !renderWidgetHostView_->selected_text().empty();
  

[Avi (use Gerrit), 2017/03/06 16:21:12]

Acknowledged.

+  BOOL hasText = selection && !selection->selected_text().empty();
   BOOL takesText =
       renderWidgetHostView_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE;
 
   if (sendTypeIsString && hasText && !returnType) {
     requestor = self;
   } else if (!sendType && returnTypeIsString && takesText) {
     requestor = self;
   } else if (sendTypeIsString && returnTypeIsString && hasText && takesText) {
     requestor = self;
   } else {
@@ skipping 56 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end