DescriptionUse SetUserText() in OmniboxViewViews emphasis tests to ensure system coherence.
The tests as first written used SetText(), which changes the text in the
textfield itself but not the text that the view/edit data structures believe is
present. Similarly, the edit model never thinks input is in progress. Since
some of the tests want to pretend input _is_ in progress, the ability to
override CurrentTextIsUrl() was introducd to hack around the issue. This does
things more "the right way".
BUG=none
TEST=none
Review-Url: https://codereview.chromium.org/2735533002
Cr-Commit-Position: refs/heads/master@{#455440}
Committed: https://chromium.googlesource.com/chromium/src/+/1b06902a8e1ba9c3dabbd48f7fcb96d7d6ceedc3
Patch Set 1 #
Total comments: 2
Patch Set 2 : Test with and without accepting input. #
Total comments: 2
Patch Set 3 : Resync #Patch Set 4 : Review comments #Patch Set 5 : Hopefully compiles #Patch Set 6 : Hopefully compiles deux #
Depends on Patchset: Messages
Total messages: 28 (21 generated)
|