Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2735533002: Use SetUserText() in OmniboxViewViews emphasis tests to ensure system coherence. (Closed)
Patch Set: Hopefully compiles deux Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 79
80 // Called when the window's active tab changes. 80 // Called when the window's active tab changes.
81 void OnTabChanged(const content::WebContents* web_contents); 81 void OnTabChanged(const content::WebContents* web_contents);
82 82
83 // Called to clear the saved state for |web_contents|. 83 // Called to clear the saved state for |web_contents|.
84 void ResetTabState(content::WebContents* web_contents); 84 void ResetTabState(content::WebContents* web_contents);
85 85
86 // OmniboxView: 86 // OmniboxView:
87 void Update() override; 87 void Update() override;
88 base::string16 GetText() const override; 88 base::string16 GetText() const override;
89 using OmniboxView::SetUserText;
89 void SetUserText(const base::string16& text, 90 void SetUserText(const base::string16& text,
90 bool update_popup) override; 91 bool update_popup) override;
91 void EnterKeywordModeForDefaultSearchProvider() override; 92 void EnterKeywordModeForDefaultSearchProvider() override;
92 void GetSelectionBounds(base::string16::size_type* start, 93 void GetSelectionBounds(base::string16::size_type* start,
93 base::string16::size_type* end) const override; 94 base::string16::size_type* end) const override;
94 void SelectAll(bool reversed) override; 95 void SelectAll(bool reversed) override;
95 void RevertAll() override; 96 void RevertAll() override;
96 void SetFocus() override; 97 void SetFocus() override;
97 int GetTextWidth() const override; 98 int GetTextWidth() const override;
98 bool IsImeComposing() const override; 99 bool IsImeComposing() const override;
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 bool select_all_on_gesture_tap_; 243 bool select_all_on_gesture_tap_;
243 244
244 // The time of the first character insert operation that has not yet been 245 // The time of the first character insert operation that has not yet been
245 // painted. Used to measure omnibox responsiveness with a histogram. 246 // painted. Used to measure omnibox responsiveness with a histogram.
246 base::TimeTicks insert_char_time_; 247 base::TimeTicks insert_char_time_;
247 248
248 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 249 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
249 }; 250 };
250 251
251 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 252 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698