Use SetUserText() in OmniboxViewViews emphasis tests to ensure system coherence.

chrome/browser/ui/views/omnibox/omnibox_view_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 67 matching lines @@
 
   // Called when the window's active tab changes.
   void OnTabChanged(const content::WebContents* web_contents);
 
   // Called to clear the saved state for |web_contents|.
   void ResetTabState(content::WebContents* web_contents);
 
   // OmniboxView:
   void Update() override;
   base::string16 GetText() const override;
+  using OmniboxView::SetUserText;

[elawrence, 2017/03/04 18:41:48]

I must plead ignorance to what this using declaration does.

[Peter Kasting, 2017/03/06 21:18:03]

It exposes the base class methods that are not overridden in this class to name
lookup.  In this case, it lets me call the one-arg SetUserText() in the base
class without doing:

  static_cast<OmniboxView*>(ptr)->SetUserText(...);

Or:

  ptr->OmniboxView::SetUserText(...);

...both of which feel more ugly, and force each caller that wants this to do it.

   void SetUserText(const base::string16& text,
                    bool update_popup) override;
   void EnterKeywordModeForDefaultSearchProvider() override;
   void GetSelectionBounds(base::string16::size_type* start,
                           base::string16::size_type* end) const override;
   void SelectAll(bool reversed) override;
   void RevertAll() override;
   void SetFocus() override;
   int GetTextWidth() const override;
   bool IsImeComposing() const override;
@@ skipping 143 matching lines @@
   bool select_all_on_gesture_tap_;
 
   // The time of the first character insert operation that has not yet been
   // painted. Used to measure omnibox responsiveness with a histogram.
   base::TimeTicks insert_char_time_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_