Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2734973002: Stop setting use_qualified_include to true now that that is the default. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, sadrul, michaelpg+watch-md-settings_chromium.org, ios-reviews+web_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, arv+watch_chromium.org, marq+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, aboxhall+watch_chromium.org, lcwu+watch_chromium.org, jam, net-reviews_chromium.org, dglazkov+blink, je_julie, darin-cc_chromium.org, halliwell+watch_chromium.org, blink-reviews, kalyank, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, alemate+watch_chromium.org, Peter Beverloo, yuzo+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, alokp+watch_chromium.org, jochen+watch_chromium.org, sdefresne+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), nektar+watch_chromium.org, blink-reviews-api_chromium.org, dtseng+watch_chromium.org, noyau+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop setting use_qualified_include to true now that that is the default. BUG=401588 TBR=brettw CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2734973002 Cr-Commit-Position: refs/heads/master@{#455354} Committed: https://chromium.googlesource.com/chromium/src/+/d50b4e5aec16f187d9a45d3eaac4593512c1cfd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -72 lines) Patch
M android_webview/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ash/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 13 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/resources/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M components/strings/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/strings/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/share_extension/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/today_extension/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/strings/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Nico
\o/
3 years, 9 months ago (2017-03-06 21:15:35 UTC) #4
Nico
Looks like thestig is away -- brettw, can you stamp this?
3 years, 9 months ago (2017-03-07 17:39:48 UTC) #15
Lei Zhang
lgtm
3 years, 9 months ago (2017-03-08 00:49:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734973002/1
3 years, 9 months ago (2017-03-08 01:17:18 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d50b4e5aec16f187d9a45d3eaac4593512c1cfd6
3 years, 9 months ago (2017-03-08 02:36:04 UTC) #24
brettw
3 years, 9 months ago (2017-03-08 22:28:45 UTC) #25
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698