Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/resources/BUILD.gn

Issue 2734973002: Stop setting use_qualified_include to true now that that is the default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chrome/common/features.gni") 5 import("//chrome/common/features.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 7
8 grit("net_internals_resources") { 8 grit("net_internals_resources") {
9 source = "net_internals_resources.grd" 9 source = "net_internals_resources.grd"
10 use_qualified_include = true
11 defines = chrome_grit_defines 10 defines = chrome_grit_defines
12 outputs = [ 11 outputs = [
13 "grit/net_internals_resources.h", 12 "grit/net_internals_resources.h",
14 "net_internals_resources.pak", 13 "net_internals_resources.pak",
15 ] 14 ]
16 output_dir = "$root_gen_dir/chrome" 15 output_dir = "$root_gen_dir/chrome"
17 } 16 }
18 17
19 grit("invalidations_resources") { 18 grit("invalidations_resources") {
20 source = "invalidations_resources.grd" 19 source = "invalidations_resources.grd"
21 use_qualified_include = true
22 defines = chrome_grit_defines 20 defines = chrome_grit_defines
23 outputs = [ 21 outputs = [
24 "grit/invalidations_resources.h", 22 "grit/invalidations_resources.h",
25 "invalidations_resources.pak", 23 "invalidations_resources.pak",
26 ] 24 ]
27 output_dir = "$root_gen_dir/chrome" 25 output_dir = "$root_gen_dir/chrome"
28 } 26 }
29 27
30 grit("password_manager_internals_resources") { 28 grit("password_manager_internals_resources") {
31 source = "password_manager_internals_resources.grd" 29 source = "password_manager_internals_resources.grd"
32 use_qualified_include = true
33 defines = chrome_grit_defines 30 defines = chrome_grit_defines
34 outputs = [ 31 outputs = [
35 "grit/password_manager_internals_resources.h", 32 "grit/password_manager_internals_resources.h",
36 "password_manager_internals_resources.pak", 33 "password_manager_internals_resources.pak",
37 ] 34 ]
38 output_dir = "$root_gen_dir/chrome" 35 output_dir = "$root_gen_dir/chrome"
39 } 36 }
40 37
41 grit("policy_resources") { 38 grit("policy_resources") {
42 source = "md_policy/policy_resources.grd" 39 source = "md_policy/policy_resources.grd"
43 defines = chrome_grit_defines 40 defines = chrome_grit_defines
44
45 # TODO(thestig): use_qualified_include = true
46 outputs = [ 41 outputs = [
47 "grit/policy_resources.h", 42 "grit/policy_resources.h",
48 "grit/policy_resources_map.cc", 43 "grit/policy_resources_map.cc",
49 "grit/policy_resources_map.h", 44 "grit/policy_resources_map.h",
50 "policy_resources.pak", 45 "policy_resources.pak",
51 ] 46 ]
52 output_dir = "$root_gen_dir/chrome" 47 output_dir = "$root_gen_dir/chrome"
53 } 48 }
54 49
55 grit("task_scheduler_internals_resources") { 50 grit("task_scheduler_internals_resources") {
56 source = "task_scheduler_internals/resources.grd" 51 source = "task_scheduler_internals/resources.grd"
57 use_qualified_include = true
58 defines = chrome_grit_defines 52 defines = chrome_grit_defines
59 outputs = [ 53 outputs = [
60 "grit/task_scheduler_internals_resources.h", 54 "grit/task_scheduler_internals_resources.h",
61 "task_scheduler_internals_resources.pak", 55 "task_scheduler_internals_resources.pak",
62 ] 56 ]
63 output_dir = "$root_gen_dir/chrome" 57 output_dir = "$root_gen_dir/chrome"
64 } 58 }
65 59
66 grit("translate_internals_resources") { 60 grit("translate_internals_resources") {
67 source = "translate_internals_resources.grd" 61 source = "translate_internals_resources.grd"
68 use_qualified_include = true
69 defines = chrome_grit_defines 62 defines = chrome_grit_defines
70 outputs = [ 63 outputs = [
71 "grit/translate_internals_resources.h", 64 "grit/translate_internals_resources.h",
72 "translate_internals_resources.pak", 65 "translate_internals_resources.pak",
73 ] 66 ]
74 output_dir = "$root_gen_dir/chrome" 67 output_dir = "$root_gen_dir/chrome"
75 } 68 }
76 69
77 if (!is_ios && !is_android) { 70 if (!is_ios && !is_android) {
78 grit("component_extension_resources") { 71 grit("component_extension_resources") {
79 source = "component_extension_resources.grd" 72 source = "component_extension_resources.grd"
80
81 # TODO(thestig): use_qualified_include = true
82 defines = chrome_grit_defines 73 defines = chrome_grit_defines
83 if (enable_hangout_services_extension) { 74 if (enable_hangout_services_extension) {
84 defines += [ "enable_hangout_services_extension" ] 75 defines += [ "enable_hangout_services_extension" ]
85 } 76 }
86 77
87 outputs = [ 78 outputs = [
88 "grit/component_extension_resources.h", 79 "grit/component_extension_resources.h",
89 "grit/component_extension_resources_map.cc", 80 "grit/component_extension_resources_map.cc",
90 "grit/component_extension_resources_map.h", 81 "grit/component_extension_resources_map.h",
91 "component_extension_resources.pak", 82 "component_extension_resources.pak",
92 ] 83 ]
93 output_dir = "$root_gen_dir/chrome" 84 output_dir = "$root_gen_dir/chrome"
94 } 85 }
95 86
96 grit("settings_resources") { 87 grit("settings_resources") {
97 if (use_vulcanize) { 88 if (use_vulcanize) {
98 source = "settings/settings_resources_vulcanized.grd" 89 source = "settings/settings_resources_vulcanized.grd"
99 deps = [ 90 deps = [
100 "//chrome/browser/resources/settings:build", 91 "//chrome/browser/resources/settings:build",
101 ] 92 ]
102 grit_flags = [ 93 grit_flags = [
103 "-E", 94 "-E",
104 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir), 95 "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
105 ] 96 ]
106 } else { 97 } else {
107 source = "settings/settings_resources.grd" 98 source = "settings/settings_resources.grd"
108 } 99 }
109 100
110 # TODO(thestig): use_qualified_include = true
111 defines = chrome_grit_defines 101 defines = chrome_grit_defines
112 outputs = [ 102 outputs = [
113 "grit/settings_resources.h", 103 "grit/settings_resources.h",
114 "grit/settings_resources_map.cc", 104 "grit/settings_resources_map.cc",
115 "grit/settings_resources_map.h", 105 "grit/settings_resources_map.h",
116 "settings_resources.pak", 106 "settings_resources.pak",
117 ] 107 ]
118 output_dir = "$root_gen_dir/chrome" 108 output_dir = "$root_gen_dir/chrome"
119 } 109 }
120 110
121 grit("options_resources") { 111 grit("options_resources") {
122 source = "options_resources.grd" 112 source = "options_resources.grd"
123 use_qualified_include = true
124 defines = chrome_grit_defines 113 defines = chrome_grit_defines
125 outputs = [ 114 outputs = [
126 "grit/options_resources.h", 115 "grit/options_resources.h",
127 "options_resources.pak", 116 "options_resources.pak",
128 ] 117 ]
129 output_dir = "$root_gen_dir/chrome" 118 output_dir = "$root_gen_dir/chrome"
130 } 119 }
131 120
132 grit("options_test_resources") { 121 grit("options_test_resources") {
133 source = "options_test_resources.grd" 122 source = "options_test_resources.grd"
134 use_qualified_include = true
135 defines = chrome_grit_defines 123 defines = chrome_grit_defines
136 outputs = [ 124 outputs = [
137 "grit/options_test_resources.h", 125 "grit/options_test_resources.h",
138 "options_test_resources.pak", 126 "options_test_resources.pak",
139 ] 127 ]
140 output_dir = "$root_gen_dir/chrome" 128 output_dir = "$root_gen_dir/chrome"
141 } 129 }
142 } 130 }
143 131
144 if (!is_ios) { 132 if (!is_ios) {
145 grit("quota_internals_resources") { 133 grit("quota_internals_resources") {
146 source = "quota_internals_resources.grd" 134 source = "quota_internals_resources.grd"
147 use_qualified_include = true
148 defines = chrome_grit_defines 135 defines = chrome_grit_defines
149 outputs = [ 136 outputs = [
150 "grit/quota_internals_resources.h", 137 "grit/quota_internals_resources.h",
151 "quota_internals_resources.pak", 138 "quota_internals_resources.pak",
152 ] 139 ]
153 output_dir = "$root_gen_dir/chrome" 140 output_dir = "$root_gen_dir/chrome"
154 } 141 }
155 142
156 grit("webapks_ui_resources") { 143 grit("webapks_ui_resources") {
157 source = "webapks_ui_resources.grd" 144 source = "webapks_ui_resources.grd"
158 use_qualified_include = true
159 defines = chrome_grit_defines 145 defines = chrome_grit_defines
160 outputs = [ 146 outputs = [
161 "grit/webapks_ui_resources.h", 147 "grit/webapks_ui_resources.h",
162 "webapks_ui_resources.pak", 148 "webapks_ui_resources.pak",
163 ] 149 ]
164 output_dir = "$root_gen_dir/chrome" 150 output_dir = "$root_gen_dir/chrome"
165 } 151 }
166 } 152 }
167 153
168 if (enable_extensions) { 154 if (enable_extensions) {
169 grit("sync_file_system_internals_resources") { 155 grit("sync_file_system_internals_resources") {
170 source = "sync_file_system_internals_resources.grd" 156 source = "sync_file_system_internals_resources.grd"
171 use_qualified_include = true
172 defines = chrome_grit_defines 157 defines = chrome_grit_defines
173 outputs = [ 158 outputs = [
174 "grit/sync_file_system_internals_resources.h", 159 "grit/sync_file_system_internals_resources.h",
175 "sync_file_system_internals_resources.pak", 160 "sync_file_system_internals_resources.pak",
176 ] 161 ]
177 output_dir = "$root_gen_dir/chrome" 162 output_dir = "$root_gen_dir/chrome"
178 } 163 }
179 } 164 }
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698