Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2440)

Unified Diff: chrome/browser/resources/BUILD.gn

Issue 2734973002: Stop setting use_qualified_include to true now that that is the default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/BUILD.gn
diff --git a/chrome/browser/resources/BUILD.gn b/chrome/browser/resources/BUILD.gn
index 231a50630a10d55ec5904bb4454eabc71b3b0e03..b84210010a512e0cd61ad472d4f5bc9bbfa837f8 100644
--- a/chrome/browser/resources/BUILD.gn
+++ b/chrome/browser/resources/BUILD.gn
@@ -7,7 +7,6 @@ import("//tools/grit/grit_rule.gni")
grit("net_internals_resources") {
source = "net_internals_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/net_internals_resources.h",
@@ -18,7 +17,6 @@ grit("net_internals_resources") {
grit("invalidations_resources") {
source = "invalidations_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/invalidations_resources.h",
@@ -29,7 +27,6 @@ grit("invalidations_resources") {
grit("password_manager_internals_resources") {
source = "password_manager_internals_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/password_manager_internals_resources.h",
@@ -41,8 +38,6 @@ grit("password_manager_internals_resources") {
grit("policy_resources") {
source = "md_policy/policy_resources.grd"
defines = chrome_grit_defines
-
- # TODO(thestig): use_qualified_include = true
outputs = [
"grit/policy_resources.h",
"grit/policy_resources_map.cc",
@@ -54,7 +49,6 @@ grit("policy_resources") {
grit("task_scheduler_internals_resources") {
source = "task_scheduler_internals/resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/task_scheduler_internals_resources.h",
@@ -65,7 +59,6 @@ grit("task_scheduler_internals_resources") {
grit("translate_internals_resources") {
source = "translate_internals_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/translate_internals_resources.h",
@@ -77,8 +70,6 @@ grit("translate_internals_resources") {
if (!is_ios && !is_android) {
grit("component_extension_resources") {
source = "component_extension_resources.grd"
-
- # TODO(thestig): use_qualified_include = true
defines = chrome_grit_defines
if (enable_hangout_services_extension) {
defines += [ "enable_hangout_services_extension" ]
@@ -107,7 +98,6 @@ if (!is_ios && !is_android) {
source = "settings/settings_resources.grd"
}
- # TODO(thestig): use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/settings_resources.h",
@@ -120,7 +110,6 @@ if (!is_ios && !is_android) {
grit("options_resources") {
source = "options_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/options_resources.h",
@@ -131,7 +120,6 @@ if (!is_ios && !is_android) {
grit("options_test_resources") {
source = "options_test_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/options_test_resources.h",
@@ -144,7 +132,6 @@ if (!is_ios && !is_android) {
if (!is_ios) {
grit("quota_internals_resources") {
source = "quota_internals_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/quota_internals_resources.h",
@@ -155,7 +142,6 @@ if (!is_ios) {
grit("webapks_ui_resources") {
source = "webapks_ui_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/webapks_ui_resources.h",
@@ -168,7 +154,6 @@ if (!is_ios) {
if (enable_extensions) {
grit("sync_file_system_internals_resources") {
source = "sync_file_system_internals_resources.grd"
- use_qualified_include = true
defines = chrome_grit_defines
outputs = [
"grit/sync_file_system_internals_resources.h",
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698