Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2734963003: Disable pausing background video-only players on desktop. (Closed)

Created:
3 years, 9 months ago by whywhat
Modified:
3 years, 9 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erickung+watch_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable pausing background video-only players on desktop. The intent is to merge this to M58 to launch the background video optimizations that do both pausing for video-only and disabling the video track for audible videos. BUG=699106 TEST=existing tests Review-Url: https://codereview.chromium.org/2734963003 Cr-Commit-Position: refs/heads/master@{#455187} Committed: https://chromium.googlesource.com/chromium/src/+/60588ea13e075f43e47cd97d6911b8c50ce5d579

Patch Set 1 #

Patch Set 2 : Cleaner change in WMPI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
whywhat
Dale, PTaL.
3 years, 9 months ago (2017-03-07 16:04:34 UTC) #3
DaleCurtis
Hmm, is there a cleaner way to do this? This changes some large chunks of ...
3 years, 9 months ago (2017-03-07 17:43:28 UTC) #5
whywhat
Cleaner change in WMPI
3 years, 9 months ago (2017-03-07 18:03:07 UTC) #8
whywhat
Does this look better? I was going to submit and revert this immediately to simply ...
3 years, 9 months ago (2017-03-07 18:09:25 UTC) #9
DaleCurtis
Yes, much better, lgtm
3 years, 9 months ago (2017-03-07 18:16:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734963003/20001
3 years, 9 months ago (2017-03-07 18:21:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/60588ea13e075f43e47cd97d6911b8c50ce5d579
3 years, 9 months ago (2017-03-07 20:09:19 UTC) #15
whywhat
3 years, 9 months ago (2017-03-07 20:30:11 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2738793002/ by avayvod@chromium.org.

The reason for reverting is: Was intended only to merge to 58..

Powered by Google App Engine
This is Rietveld 408576698