Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2696423003: Don't pause suspended videos with no audio. (Closed)

Created:
3 years, 10 months ago by whywhat
Modified:
3 years, 9 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't pause suspended videos with no audio. This came up in some earlier code review. The purpose of the timer is to pause audible backgrounded videos so they don't surprise user when the tab is foregrounded. Video only players don't have this problem and they often don't have a play button to resume playback. BUG=None Review-Url: https://codereview.chromium.org/2696423003 Cr-Commit-Position: refs/heads/master@{#455224} Committed: https://chromium.googlesource.com/chromium/src/+/52efd28a984d8b4f5afdd9a3a6be1654499db1a3

Patch Set 1 #

Patch Set 2 : Added WMPI tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
whywhat
PTaL
3 years, 10 months ago (2017-02-16 20:43:33 UTC) #2
DaleCurtis
Seems okay, WMPI test? lgtm
3 years, 10 months ago (2017-02-16 20:48:27 UTC) #3
whywhat
Added WMPI tests
3 years, 9 months ago (2017-03-07 18:59:18 UTC) #4
whywhat
On 2017/02/16 at 20:48:27, dalecurtis wrote: > Seems okay, WMPI test? lgtm Done.
3 years, 9 months ago (2017-03-07 18:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696423003/20001
3 years, 9 months ago (2017-03-07 19:01:05 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:18:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/52efd28a984d8b4f5afdd9a3a6be...

Powered by Google App Engine
This is Rietveld 408576698