content/browser/media/session/media_session_impl_visibility_browsertest.cc - Issue 2734963003: Disable pausing background video-only players on desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_impl_visibility_browsertest.cc

Issue 2734963003: Disable pausing background video-only players on desktop. (Closed)

Patch Set: Cleaner change in WMPI Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/session/media_session_impl_visibility_browsertest.cc

diff --git a/content/browser/media/session/media_session_impl_visibility_browsertest.cc b/content/browser/media/session/media_session_impl_visibility_browsertest.cc

index 774183359402f0c4ea3d8c115c56a6061fb9a87a..68e99aa06ef2c0ce84f8ff748e063bcbd263f228 100644

--- a/content/browser/media/session/media_session_impl_visibility_browsertest.cc

+++ b/content/browser/media/session/media_session_impl_visibility_browsertest.cc

@@ -251,7 +251,12 @@ VisibilityTestData kTestParams[] = {

{MediaSuspend::ENABLED, BackgroundResuming::DISABLED, SessionState::ACTIVE,

SessionState::INACTIVE},

{MediaSuspend::ENABLED, BackgroundResuming::ENABLED, SessionState::ACTIVE,

+// TODO(avayvod): Revert after merge to 58. See https://crbug.com/699106.

+#if defined(OS_ANDROID)

SessionState::SUSPENDED},

+#else

+ SessionState::ACTIVE},

+#endif

{MediaSuspend::ENABLED, BackgroundResuming::ENABLED,

SessionState::SUSPENDED, SessionState::SUSPENDED},

{MediaSuspend::DISABLED, BackgroundResuming::DISABLED,

« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »