Adding 'Show Host List' option to CTD

Adding 'Show Host List' option to CTD

Previous tool behavior for retrieving and showing the host list was
linked to test case execution but there are times where we may want to
display a list of hosts for troubleshooting.  I've added a switch to the
tool to display the list and bail out, I've also refactored a bit to
make the impl cleaner.

BUG=

Review-Url: https://codereview.chromium.org/2734543002
Cr-Commit-Position: refs/heads/master@{#454904}
Committed: https://chromium.googlesource.com/chromium/src/+/22a4567d56bc34730ebce60aa7157a8ab35e1415

[joedow, 2017-03-03 20:54:26]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 20:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2017-03-03 20:56:31]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 20:56:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2017-03-03 20:56:53]

joedow@chromium.org changed reviewers:
+ garykac@chromium.org

[joedow, 2017-03-03 20:56:54]

PTAL!

[garykac, 2017-03-03 21:01:58]

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
File remoting/test/chromoting_test_driver_environment.cc (right):

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_environment.cc:91:
printf(kHostAvailabilityFormatString, "Host Name", "Host Status", "Host JID");
Is the switch to printf intentional?

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_environment.cc:122: int num_iterations = 0;
No longer used.

[commit-bot: I haz the power, 2017-03-03 21:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 21:03:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joedow, 2017-03-03 22:40:50]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:41:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2017-03-03 22:45:59]

Addressed feedback, PTAL!

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
File remoting/test/chromoting_test_driver_environment.cc (right):

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_environment.cc:91:
printf(kHostAvailabilityFormatString, "Host Name", "Host Status", "Host JID");
On 2017/03/03 21:01:58, garykac wrote:
> Is the switch to printf intentional?

It was intentional.  Using LOG will prepend a bunch of info that makes the table
less readable IMO and less likely to fit within the a standard command window
without resizing.

https://codereview.chromium.org/2734543002/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_environment.cc:122: int num_iterations = 0;
On 2017/03/03 21:01:58, garykac wrote:
> No longer used.

Good catch

[commit-bot: I haz the power, 2017-03-03 22:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:56:26]

Dry run: This issue passed the CQ dry run.

[joedow, 2017-03-06 17:06:06]

Ping!

[garykac, 2017-03-06 18:25:23]

The CQ bit was checked by garykac@chromium.org

[garykac, 2017-03-06 18:25:23]

lgtm

[commit-bot: I haz the power, 2017-03-06 18:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 18:49:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488824723223320,
"parent_rev": "25ce290e11c1d6058bb12ae2fbfd524938abd81f", "commit_rev":
"22a4567d56bc34730ebce60aa7157a8ab35e1415"}

[commit-bot: I haz the power, 2017-03-06 18:50:02]

Description was changed from

==========
Adding 'Show Host List' option to CTD

Previous tool behavior for retrieving and showing the host list was
linked to test case execution but there are times where we may want to
display a list of hosts for troubleshooting.  I've added a switch to the
tool to display the list and bail out, I've also refactored a bit to
make the impl cleaner.

BUG=
==========

to

==========
Adding 'Show Host List' option to CTD

Previous tool behavior for retrieving and showing the host list was
linked to test case execution but there are times where we may want to
display a list of hosts for troubleshooting.  I've added a switch to the
tool to display the list and bail out, I've also refactored a bit to
make the impl cleaner.

BUG=

Review-Url: https://codereview.chromium.org/2734543002
Cr-Commit-Position: refs/heads/master@{#454904}
Committed:
https://chromium.googlesource.com/chromium/src/+/22a4567d56bc34730ebce60aa715...
==========

[commit-bot: I haz the power, 2017-03-06 18:50:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/22a4567d56bc34730ebce60aa715...