Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: remoting/test/chromoting_test_driver_environment.h

Issue 2734543002: Adding 'Show Host List' option to CTD (Closed)
Patch Set: Addressing comments and fixing unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/test/chromoting_test_driver.cc ('k') | remoting/test/chromoting_test_driver_environment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/test/chromoting_test_driver_environment.h
diff --git a/remoting/test/chromoting_test_driver_environment.h b/remoting/test/chromoting_test_driver_environment.h
index df2cb21e94f8800be85a3ea38e2b309fc517a0d4..90d113490b1d6f71d9c8c9123a3341e2e3505d48 100644
--- a/remoting/test/chromoting_test_driver_environment.h
+++ b/remoting/test/chromoting_test_driver_environment.h
@@ -49,14 +49,16 @@ class ChromotingTestDriverEnvironment : public testing::Environment {
// Returns false if a valid access token cannot be retrieved.
bool Initialize(const std::string& auth_code);
+ // Clears and then retrieves a new host list.
+ bool RefreshHostList();
+
// Retrieves connection information for all known hosts and displays
// their availability to STDOUT.
void DisplayHostList();
// Waits for either the host to come online or a maximum timeout. Returns true
- // if host is found online.
- bool WaitForHostOnline(const std::string& host_jid,
- const std::string& host_name);
+ // if host is found online and |host_info_| is valid.
+ bool WaitForHostOnline();
// Used to set fake/mock objects for ChromotingTestDriverEnvironment tests.
// The caller retains ownership of the supplied objects, and must ensure that
@@ -95,12 +97,11 @@ class ChromotingTestDriverEnvironment : public testing::Environment {
const std::string& retrieved_refresh_token);
// Used to retrieve a host list from the directory service.
- // Returns true if the request was successful, |host_list_| is valid, and
- // |host_info_| has been set.
+ // Returns true if the request was successful and |host_list_| is valid.
bool RetrieveHostList();
- // Clears and then retrieves a new host list.
- bool RefreshHostList();
+ // Sets |host_info_| if the requested host exists in the host list.
+ bool FindHostInHostList();
// Called after the host info fetcher completes.
void OnHostListRetrieved(base::Closure done_closure,
« no previous file with comments | « remoting/test/chromoting_test_driver.cc ('k') | remoting/test/chromoting_test_driver_environment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698