Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2730133002: Fixing Chromoting_test_driver target (Closed)

Created:
3 years, 9 months ago by joedow
Modified:
3 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing Chromoting_test_driver target A recent CL introduced a new TaskScheduler component which requires initialization before use. Other CRD binaries were fixed but this tool was not updated, this led to a crash when attempting to retrieve the host list. I have fixed the crash by adding the standard init code used in other CRD binaries to this tool. BUG= Review-Url: https://codereview.chromium.org/2730133002 Cr-Commit-Position: refs/heads/master@{#454672} Committed: https://chromium.googlesource.com/chromium/src/+/f28d751a1344ed2c80aabc2cf85ce9125c33f34c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/test/chromoting_test_driver.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
joedow
PTAL!
3 years, 9 months ago (2017-03-03 20:13:04 UTC) #6
garykac
lgtm
3 years, 9 months ago (2017-03-03 20:58:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730133002/1
3 years, 9 months ago (2017-03-03 20:59:26 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 21:08:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f28d751a1344ed2c80aabc2cf85c...

Powered by Google App Engine
This is Rietveld 408576698