[cleanup] Refactor remaining builtins-*.cc to use TF_BUILTIN macro

[cleanup] Refactor remaining builtins-*.cc to use TF_BUILTIN macro

Review-Url: https://codereview.chromium.org/2734323004
Cr-Commit-Position: refs/heads/master@{#43695}
Committed: https://chromium.googlesource.com/v8/v8/+/3e363204fea504376324ce89b858a4993a188464

[Jakob Kummerow, 2017-03-08 19:43:49]

jkummerow@chromium.org changed reviewers:
+ jgruber@chromium.org

[Jakob Kummerow, 2017-03-08 19:43:50]

PTAL. Mostly mechanical, except where annotated.

https://codereview.chromium.org/2734323004/diff/20001/src/builtins/builtins-a...
File src/builtins/builtins-array.cc (left):

https://codereview.chromium.org/2734323004/diff/20001/src/builtins/builtins-a...
src/builtins/builtins-array.cc:2141: assembler.Bind(&undef_loop);
I've dropped this. It's the same as |ident_loop| anyway.

https://codereview.chromium.org/2734323004/diff/20001/src/builtins/builtins-s...
File src/builtins/builtins-sharedarraybuffer.cc (left):

https://codereview.chromium.org/2734323004/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-sharedarraybuffer.cc:35: CodeStubAssembler::Label
is_smi(a), not_smi(a), is_typed_array(a),
Using "GotoIf" instead of "Branch" a couple of times below made most of these
labels unnecessary.

https://codereview.chromium.org/2734323004/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-sharedarraybuffer.cc:146: // TODO(jkummerow): Use unsigned
comparison instead of "i<0 || i>length".
Taking care of this TODO while I'm here :-)

[jgruber, 2017-03-09 07:41:43]

lgtm, thanks for doing this.

Now if we could only make interpreter.cc as nice as this :)

[Jakob Kummerow, 2017-03-09 11:59:43]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 11:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 12:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 12:03:40]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Jakob Kummerow, 2017-03-09 12:10:14]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 12:10:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 12:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 12:37:38]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2017-03-09 12:38:51]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-03-09 12:38:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2734323004/#ps40001
(title: "drop unused variable")

[commit-bot: I haz the power, 2017-03-09 12:38:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:38:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489063131583640,
"parent_rev": "f58177dd923f79295b6e625c849d37ce9be70d29", "commit_rev":
"3e363204fea504376324ce89b858a4993a188464"}

[commit-bot: I haz the power, 2017-03-09 13:38:14]

Description was changed from

==========
[cleanup] Refactor remaining builtins-*.cc to use TF_BUILTIN macro
==========

to

==========
[cleanup] Refactor remaining builtins-*.cc to use TF_BUILTIN macro

Review-Url: https://codereview.chromium.org/2734323004
Cr-Commit-Position: refs/heads/master@{#43695}
Committed:
https://chromium.googlesource.com/v8/v8/+/3e363204fea504376324ce89b858a4993a1...
==========

[commit-bot: I haz the power, 2017-03-09 13:38:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/3e363204fea504376324ce89b858a4993a1...