Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/builtins/builtins-symbol.cc

Issue 2734323004: [cleanup] Refactor remaining builtins-*.cc to use TF_BUILTIN macro (Closed)
Patch Set: drop unused variable Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-sharedarraybuffer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-symbol.cc
diff --git a/src/builtins/builtins-symbol.cc b/src/builtins/builtins-symbol.cc
index f57d0bffd9f9fd227a77065b953aa14220ec0ea1..43cb8c89a90a29c44526c332bb9b5ff2aea60cb2 100644
--- a/src/builtins/builtins-symbol.cc
+++ b/src/builtins/builtins-symbol.cc
@@ -68,48 +68,34 @@ BUILTIN(SymbolKeyFor) {
}
// ES6 section 19.4.3.4 Symbol.prototype [ @@toPrimitive ] ( hint )
-void Builtins::Generate_SymbolPrototypeToPrimitive(
- compiler::CodeAssemblerState* state) {
- typedef compiler::Node Node;
- CodeStubAssembler assembler(state);
+TF_BUILTIN(SymbolPrototypeToPrimitive, CodeStubAssembler) {
+ Node* receiver = Parameter(0);
+ Node* context = Parameter(4);
- Node* receiver = assembler.Parameter(0);
- Node* context = assembler.Parameter(4);
-
- Node* result =
- assembler.ToThisValue(context, receiver, PrimitiveType::kSymbol,
- "Symbol.prototype [ @@toPrimitive ]");
- assembler.Return(result);
+ Node* result = ToThisValue(context, receiver, PrimitiveType::kSymbol,
+ "Symbol.prototype [ @@toPrimitive ]");
+ Return(result);
}
// ES6 section 19.4.3.2 Symbol.prototype.toString ( )
-void Builtins::Generate_SymbolPrototypeToString(
- compiler::CodeAssemblerState* state) {
- typedef compiler::Node Node;
- CodeStubAssembler assembler(state);
-
- Node* receiver = assembler.Parameter(0);
- Node* context = assembler.Parameter(3);
-
- Node* value = assembler.ToThisValue(context, receiver, PrimitiveType::kSymbol,
- "Symbol.prototype.toString");
- Node* result =
- assembler.CallRuntime(Runtime::kSymbolDescriptiveString, context, value);
- assembler.Return(result);
+TF_BUILTIN(SymbolPrototypeToString, CodeStubAssembler) {
+ Node* receiver = Parameter(0);
+ Node* context = Parameter(3);
+
+ Node* value = ToThisValue(context, receiver, PrimitiveType::kSymbol,
+ "Symbol.prototype.toString");
+ Node* result = CallRuntime(Runtime::kSymbolDescriptiveString, context, value);
+ Return(result);
}
// ES6 section 19.4.3.3 Symbol.prototype.valueOf ( )
-void Builtins::Generate_SymbolPrototypeValueOf(
- compiler::CodeAssemblerState* state) {
- typedef compiler::Node Node;
- CodeStubAssembler assembler(state);
-
- Node* receiver = assembler.Parameter(0);
- Node* context = assembler.Parameter(3);
+TF_BUILTIN(SymbolPrototypeValueOf, CodeStubAssembler) {
+ Node* receiver = Parameter(0);
+ Node* context = Parameter(3);
- Node* result = assembler.ToThisValue(
- context, receiver, PrimitiveType::kSymbol, "Symbol.prototype.valueOf");
- assembler.Return(result);
+ Node* result = ToThisValue(context, receiver, PrimitiveType::kSymbol,
+ "Symbol.prototype.valueOf");
+ Return(result);
}
} // namespace internal
« no previous file with comments | « src/builtins/builtins-sharedarraybuffer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698