Move final vector icons out of ui/gfx/vector_icons/ and remove the

Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG=626786
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2733823003
Cr-Commit-Position: refs/heads/master@{#455689}
Committed: https://chromium.googlesource.com/chromium/src/+/3b0d20258d8d2009595e515010ae04f92208f4ee

[Evan Stade, 2017-03-07 03:46:19]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 03:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:00:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Evan Stade, 2017-03-07 17:11:16]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 17:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 17:25:28]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Evan Stade, 2017-03-07 22:40:04]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 22:41:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 22:54:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Evan Stade, 2017-03-07 23:54:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 23:55:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-03-08 00:47:09]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-03-08 00:47:10]

mostly mechanical, only real change of note is that there are now two
check_circle.icon definitions, and one is particular to ash/. The one in
ui/vector_icons/ is a restoration of the version that existed before ash started
using it and someone changed it to suit ash.

[commit-bot: I haz the power, 2017-03-08 00:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:54:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-03-08 05:26:37]

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_match.cc (right):

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
components/omnibox/browser/autocomplete_match.cc:202: return ui::kSearchIcon;
I have a preference for keeping the icon close to the code. Is there a
particularly reason to move the icon to ui? What's wrong with keeping it here?

https://codereview.chromium.org/2733823003/diff/80001/ui/vector_icons/BUILD.gn
File ui/vector_icons/BUILD.gn (right):

https://codereview.chromium.org/2733823003/diff/80001/ui/vector_icons/BUILD.g...
ui/vector_icons/BUILD.gn:30: "notifications_off.icon",
Can this be moved to message_center code? In fact can we move all icons that are
only consumed in one place to the place the uses them?

[Evan Stade, 2017-03-08 17:37:39]

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_match.cc (right):

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
components/omnibox/browser/autocomplete_match.cc:202: return ui::kSearchIcon;
On 2017/03/08 05:26:37, sky wrote:
> I have a preference for keeping the icon close to the code. Is there a
> particularly reason to move the icon to ui? What's wrong with keeping it here?

this icon is used in:

ash/
chrome/browser/
components/omnibox/

previous to this CL it was duplicated so that ash could use it.

https://codereview.chromium.org/2733823003/diff/80001/ui/vector_icons/BUILD.gn
File ui/vector_icons/BUILD.gn (right):

https://codereview.chromium.org/2733823003/diff/80001/ui/vector_icons/BUILD.g...
ui/vector_icons/BUILD.gn:30: "notifications_off.icon",
On 2017/03/08 05:26:37, sky wrote:
> Can this be moved to message_center code? In fact can we move all icons that
are
> only consumed in one place to the place the uses them?

This is actually used in chrome/browser/chromeos/eol_notification.cc rather than
the notification center. That said, as discussed here[1] where we put the
notifications.icon in this directory, I wanted to put this here because

a) it's a stock md icon
b) it seems likely to be reused by or useful to other components like ash/.
Whenever the message center is eventually updated, it should replace
notification_do_not_disturb.png
c) to keep it next to the related notifications.icon

[1] https://codereview.chromium.org/2685683004

[sky, 2017-03-08 18:46:08]

ok, LGTM

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
File components/omnibox/browser/autocomplete_match.cc (right):

https://codereview.chromium.org/2733823003/diff/80001/components/omnibox/brow...
components/omnibox/browser/autocomplete_match.cc:202: return ui::kSearchIcon;
On 2017/03/08 17:37:39, Evan Stade wrote:
> On 2017/03/08 05:26:37, sky wrote:
> > I have a preference for keeping the icon close to the code. Is there a
> > particularly reason to move the icon to ui? What's wrong with keeping it
here?
> 
> this icon is used in:
> 
> ash/
> chrome/browser/
> components/omnibox/
> 
> previous to this CL it was duplicated so that ash could use it.

Ok, makes sense.

[Evan Stade, 2017-03-08 20:00:02]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-08 20:00:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2733823003/#ps120001
(title: "fix bad merge")

[commit-bot: I haz the power, 2017-03-08 20:00:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 20:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 20:07:12]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Evan Stade, 2017-03-09 03:27:30]

Description was changed from

==========
Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG=626786
==========

to

==========
Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG=626786
TBR=rohitrao@chromium.org
==========

[Evan Stade, 2017-03-09 03:27:31]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org, rohitrao@chromium.org

[Evan Stade, 2017-03-09 03:28:09]

+pkasting for components/omnibox and components/toolbar OWNERS
+rohitrao TBR for ios

[Evan Stade, 2017-03-09 03:28:18]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 03:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 03:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 03:33:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Peter Kasting, 2017-03-09 06:13:26]

LGTM

[Evan Stade, 2017-03-09 06:24:20]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-09 06:24:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2733823003/#ps140001
(title: "fix deps")

[commit-bot: I haz the power, 2017-03-09 06:24:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 07:25:23]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489040660543080,
"parent_rev": "86769268e85c0913ef8d86c46ff08baff599703e", "commit_rev":
"3b0d20258d8d2009595e515010ae04f92208f4ee"}

[commit-bot: I haz the power, 2017-03-09 07:26:26]

Description was changed from

==========
Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG=626786
TBR=rohitrao@chromium.org
==========

to

==========
Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG=626786
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2733823003
Cr-Commit-Position: refs/heads/master@{#455689}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b0d20258d8d2009595e515010ae...
==========

[commit-bot: I haz the power, 2017-03-09 07:26:30]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/3b0d20258d8d2009595e515010ae...