OLD | NEW |
1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
| 5 #include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h" |
5 #include "base/command_line.h" | 6 #include "base/command_line.h" |
6 #include "base/logging.h" | 7 #include "base/logging.h" |
7 #include "base/memory/ptr_util.h" | 8 #include "base/memory/ptr_util.h" |
8 #include "base/path_service.h" | 9 #include "base/path_service.h" |
9 #include "base/values.h" | 10 #include "base/values.h" |
10 #include "chrome/browser/extensions/extension_service.h" | 11 #include "chrome/browser/extensions/extension_service.h" |
11 #include "chrome/browser/extensions/extension_service_test_with_install.h" | 12 #include "chrome/browser/extensions/extension_service_test_with_install.h" |
12 #include "chrome/browser/extensions/extension_web_ui_override_registrar.h" | 13 #include "chrome/browser/extensions/extension_web_ui_override_registrar.h" |
13 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h" | 14 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h" |
14 #include "chrome/browser/extensions/suspicious_extension_bubble_delegate.h" | 15 #include "chrome/browser/extensions/suspicious_extension_bubble_delegate.h" |
15 #include "chrome/browser/ui/browser.h" | 16 #include "chrome/browser/ui/browser.h" |
16 #include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h" | |
17 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h" | 17 #include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h" |
18 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h" | 18 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h" |
19 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h" | 19 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h" |
20 #include "chrome/browser/ui/toolbar/toolbar_actions_model_factory.h" | 20 #include "chrome/browser/ui/toolbar/toolbar_actions_model_factory.h" |
21 #include "chrome/common/chrome_paths.h" | 21 #include "chrome/common/chrome_paths.h" |
22 #include "chrome/grit/generated_resources.h" | 22 #include "chrome/grit/generated_resources.h" |
23 #include "chrome/test/base/test_browser_window.h" | 23 #include "chrome/test/base/test_browser_window.h" |
24 #include "chrome/test/base/testing_profile.h" | 24 #include "chrome/test/base/testing_profile.h" |
25 #include "components/crx_file/id_util.h" | 25 #include "components/crx_file/id_util.h" |
26 #include "components/grit/components_scaled_resources.h" | 26 #include "components/grit/components_scaled_resources.h" |
27 #include "components/keyed_service/core/keyed_service.h" | 27 #include "components/keyed_service/core/keyed_service.h" |
28 #include "components/strings/grit/components_strings.h" | 28 #include "components/strings/grit/components_strings.h" |
29 #include "content/public/browser/browser_context.h" | 29 #include "content/public/browser/browser_context.h" |
30 #include "extensions/browser/extension_registry.h" | 30 #include "extensions/browser/extension_registry.h" |
31 #include "extensions/browser/extension_system.h" | 31 #include "extensions/browser/extension_system.h" |
32 #include "extensions/common/extension_builder.h" | 32 #include "extensions/common/extension_builder.h" |
33 #include "extensions/common/manifest.h" | 33 #include "extensions/common/manifest.h" |
34 #include "extensions/common/value_builder.h" | 34 #include "extensions/common/value_builder.h" |
35 #include "testing/gtest/include/gtest/gtest.h" | 35 #include "testing/gtest/include/gtest/gtest.h" |
36 #include "ui/base/l10n/l10n_util.h" | 36 #include "ui/base/l10n/l10n_util.h" |
37 #include "ui/gfx/vector_icons_public.h" | 37 #include "ui/vector_icons/vector_icons.h" |
38 | 38 |
39 namespace { | 39 namespace { |
40 | 40 |
41 std::unique_ptr<KeyedService> BuildOverrideRegistrar( | 41 std::unique_ptr<KeyedService> BuildOverrideRegistrar( |
42 content::BrowserContext* context) { | 42 content::BrowserContext* context) { |
43 return base::MakeUnique<extensions::ExtensionWebUIOverrideRegistrar>(context); | 43 return base::MakeUnique<extensions::ExtensionWebUIOverrideRegistrar>(context); |
44 } | 44 } |
45 | 45 |
46 std::unique_ptr<KeyedService> BuildToolbarModel( | 46 std::unique_ptr<KeyedService> BuildToolbarModel( |
47 content::BrowserContext* context) { | 47 content::BrowserContext* context) { |
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
101 browser())); | 101 browser())); |
102 | 102 |
103 ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size()); | 103 ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size()); |
104 | 104 |
105 std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge( | 105 std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge( |
106 new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller))); | 106 new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller))); |
107 | 107 |
108 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> | 108 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> |
109 extra_view_info = bridge->GetExtraViewInfo(); | 109 extra_view_info = bridge->GetExtraViewInfo(); |
110 | 110 |
111 EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE, extra_view_info->resource_id); | 111 EXPECT_FALSE(extra_view_info->resource); |
112 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_LEARN_MORE), extra_view_info->text); | 112 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_LEARN_MORE), extra_view_info->text); |
113 EXPECT_TRUE(extra_view_info->is_text_linked); | 113 EXPECT_TRUE(extra_view_info->is_text_linked); |
114 | 114 |
115 EXPECT_EQ( | 115 EXPECT_EQ( |
116 l10n_util::GetStringUTF16(IDS_EXTENSION_CONTROLLED_RESTORE_SETTINGS), | 116 l10n_util::GetStringUTF16(IDS_EXTENSION_CONTROLLED_RESTORE_SETTINGS), |
117 bridge->GetActionButtonText()); | 117 bridge->GetActionButtonText()); |
118 } | 118 } |
119 | 119 |
120 TEST_F(ExtensionMessageBubbleBridgeUnitTest, | 120 TEST_F(ExtensionMessageBubbleBridgeUnitTest, |
121 TestGetExtraViewInfoMethodWithPolicyInstalledSettingsOverrideExtension) { | 121 TestGetExtraViewInfoMethodWithPolicyInstalledSettingsOverrideExtension) { |
(...skipping 10 matching lines...) Expand all Loading... |
132 ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size()); | 132 ASSERT_EQ(1U, ntp_bubble_controller->GetExtensionList().size()); |
133 | 133 |
134 std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge( | 134 std::unique_ptr<ToolbarActionsBarBubbleDelegate> bridge( |
135 new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller))); | 135 new ExtensionMessageBubbleBridge(std::move(ntp_bubble_controller))); |
136 | 136 |
137 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> | 137 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> |
138 extra_view_info = bridge->GetExtraViewInfo(); | 138 extra_view_info = bridge->GetExtraViewInfo(); |
139 | 139 |
140 extra_view_info = bridge->GetExtraViewInfo(); | 140 extra_view_info = bridge->GetExtraViewInfo(); |
141 | 141 |
142 EXPECT_EQ(gfx::VectorIconId::BUSINESS, extra_view_info->resource_id); | 142 EXPECT_EQ(&ui::kBusinessIcon, extra_view_info->resource); |
143 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALLED_BY_ADMIN), | 143 EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALLED_BY_ADMIN), |
144 extra_view_info->text); | 144 extra_view_info->text); |
145 EXPECT_FALSE(extra_view_info->is_text_linked); | 145 EXPECT_FALSE(extra_view_info->is_text_linked); |
146 | 146 |
147 EXPECT_EQ(base::string16(), bridge->GetActionButtonText()); | 147 EXPECT_EQ(base::string16(), bridge->GetActionButtonText()); |
148 } | 148 } |
149 | 149 |
150 // Tests the ExtensionMessageBubbleBridge in conjunction with the | 150 // Tests the ExtensionMessageBubbleBridge in conjunction with the |
151 // SuspiciousExtensionBubbleDelegate. | 151 // SuspiciousExtensionBubbleDelegate. |
152 TEST_F(ExtensionMessageBubbleBridgeUnitTest, SuspiciousExtensionBubble) { | 152 TEST_F(ExtensionMessageBubbleBridgeUnitTest, SuspiciousExtensionBubble) { |
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
188 std::move(suspicious_bubble_controller)); | 188 std::move(suspicious_bubble_controller)); |
189 EXPECT_TRUE(bridge->ShouldShow()); | 189 EXPECT_TRUE(bridge->ShouldShow()); |
190 EXPECT_FALSE(bridge->ShouldCloseOnDeactivate()); | 190 EXPECT_FALSE(bridge->ShouldCloseOnDeactivate()); |
191 | 191 |
192 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> | 192 std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo> |
193 extra_view_info = bridge->GetExtraViewInfo(); | 193 extra_view_info = bridge->GetExtraViewInfo(); |
194 | 194 |
195 ASSERT_TRUE(extra_view_info); | 195 ASSERT_TRUE(extra_view_info); |
196 EXPECT_FALSE(extra_view_info->text.empty()); | 196 EXPECT_FALSE(extra_view_info->text.empty()); |
197 EXPECT_TRUE(extra_view_info->is_text_linked); | 197 EXPECT_TRUE(extra_view_info->is_text_linked); |
198 EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE, | 198 EXPECT_FALSE(extra_view_info->resource); |
199 extra_view_info->resource_id); | |
200 } | 199 } |
OLD | NEW |