Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4384)

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc

Issue 2733823003: Move final vector icons out of ui/gfx/vector_icons/ and remove the (Closed)
Patch Set: fix deps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
diff --git a/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc b/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
index bbf6f6f0f647a06b5a753239dff4af4979eb6766..36e188cf654701ac8fe13710ee40b7ac8be43453 100644
--- a/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
+++ b/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
@@ -13,7 +14,6 @@
#include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"
#include "chrome/browser/extensions/suspicious_extension_bubble_delegate.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
#include "chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
@@ -34,7 +34,7 @@
#include "extensions/common/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/gfx/vector_icons_public.h"
+#include "ui/vector_icons/vector_icons.h"
namespace {
@@ -108,7 +108,7 @@ TEST_F(ExtensionMessageBubbleBridgeUnitTest,
std::unique_ptr<ToolbarActionsBarBubbleDelegate::ExtraViewInfo>
extra_view_info = bridge->GetExtraViewInfo();
- EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE, extra_view_info->resource_id);
+ EXPECT_FALSE(extra_view_info->resource);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_LEARN_MORE), extra_view_info->text);
EXPECT_TRUE(extra_view_info->is_text_linked);
@@ -139,7 +139,7 @@ TEST_F(ExtensionMessageBubbleBridgeUnitTest,
extra_view_info = bridge->GetExtraViewInfo();
- EXPECT_EQ(gfx::VectorIconId::BUSINESS, extra_view_info->resource_id);
+ EXPECT_EQ(&ui::kBusinessIcon, extra_view_info->resource);
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALLED_BY_ADMIN),
extra_view_info->text);
EXPECT_FALSE(extra_view_info->is_text_linked);
@@ -195,6 +195,5 @@ TEST_F(ExtensionMessageBubbleBridgeUnitTest, SuspiciousExtensionBubble) {
ASSERT_TRUE(extra_view_info);
EXPECT_FALSE(extra_view_info->text.empty());
EXPECT_TRUE(extra_view_info->is_text_linked);
- EXPECT_EQ(gfx::VectorIconId::VECTOR_ICON_NONE,
- extra_view_info->resource_id);
+ EXPECT_FALSE(extra_view_info->resource);
}

Powered by Google App Engine
This is Rietveld 408576698