third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: Addressed the easier reviewer comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h ('k') | third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

index 8d547e9e873ddebf506c6f598d547c8c20af246f..d3c4d46a2bac2211e00b7ab60e22861e2cc716d9 100644

--- a/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

@@ -80,6 +80,8 @@ FloatSize StickyPositionScrollingConstraints::computeStickyOffset(

m_totalContainingBlockStickyOffset =

ancestorStickyBoxOffset + ancestorContainingBlockOffset + stickyOffset;

+ m_localStickyOffset = stickyOffset;

return stickyOffset;

}