Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)
Patch Set: Addressed the easier reviewer comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
diff --git a/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h b/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
index 296496d76f24a22d2545fa38c5d5c6555e31f2ef..8a83b2b92df6d1dffd853090b7f1509697f60aec 100644
--- a/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
+++ b/third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h
@@ -31,6 +31,8 @@
namespace blink {
+class WebLayer;
+
// TODO(flackr): Combine with WebLayerPositionConstraint.
struct WebLayerStickyPositionConstraint {
// True if the layer is sticky.
@@ -62,6 +64,11 @@ struct WebLayerStickyPositionConstraint {
// element should not be shifted beyond.
WebRect scrollContainerRelativeContainingBlockRect;
+ WebLayer* nearestLayerShiftingStickyBox;
+ WebLayer* nearestLayerShiftingContainingBlock;
+
+ WebFloatSize localStickyOffset;
+
WebLayerStickyPositionConstraint()
: isSticky(false),
isAnchoredLeft(false),
@@ -71,7 +78,9 @@ struct WebLayerStickyPositionConstraint {
leftOffset(0.f),
rightOffset(0.f),
topOffset(0.f),
- bottomOffset(0.f) {}
+ bottomOffset(0.f),
+ nearestLayerShiftingStickyBox(nullptr),
+ nearestLayerShiftingContainingBlock(nullptr) {}
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698