third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: Addressed the easier reviewer comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/property_tree.cc ('K') | « third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.h ('k') | third_party/WebKit/public/platform/WebLayerStickyPositionConstraint.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h"	5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h"

6	6

7 namespace blink {	7 namespace blink {

8	8

9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset(	9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset(

10 const FloatRect& viewportRect,	10 const FloatRect& viewportRect,

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73	73

74 boxRect.move(0, topDelta);	74 boxRect.move(0, topDelta);

75 }	75 }

76	76

77 FloatSize stickyOffset = boxRect.location() - stickyBoxRect.location();	77 FloatSize stickyOffset = boxRect.location() - stickyBoxRect.location();

78	78

79 m_totalStickyBoxStickyOffset = ancestorStickyBoxOffset + stickyOffset;	79 m_totalStickyBoxStickyOffset = ancestorStickyBoxOffset + stickyOffset;

80 m_totalContainingBlockStickyOffset =	80 m_totalContainingBlockStickyOffset =

81 ancestorStickyBoxOffset + ancestorContainingBlockOffset + stickyOffset;	81 ancestorStickyBoxOffset + ancestorContainingBlockOffset + stickyOffset;

82	82

	83 m_localStickyOffset = stickyOffset;

	84

83 return stickyOffset;	85 return stickyOffset;

84 }	86 }

85	87

86 } // namespace blink	88 } // namespace blink

OLD	NEW