Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2733493002: DevTools: fix bug with persisting drawer selection (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix bug with persisting drawer selection BUG=698068 Review-Url: https://codereview.chromium.org/2733493002 Cr-Commit-Position: refs/heads/master@{#456578} Committed: https://chromium.googlesource.com/chromium/src/+/345a7614774506af8d576a396b4b95acc7fc63c7

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/inspector/help/release-note.html View 1 2 1 chunk +3 lines, -3 lines 1 comment Download
M third_party/WebKit/LayoutTests/inspector/help/release-note-unit.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/help/Help.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
chenwilliam
I noticed this issue first w/ What's New and then realized this was a general ...
3 years, 9 months ago (2017-03-03 00:07:55 UTC) #2
chenwilliam
ptal - I had to change our solution from yesterday to make it work for ...
3 years, 9 months ago (2017-03-09 18:57:35 UTC) #3
chenwilliam
dgozman@ ptal. This bug is blocking release note.
3 years, 9 months ago (2017-03-13 17:58:59 UTC) #5
chenwilliam
ptal, thanks
3 years, 9 months ago (2017-03-13 21:02:12 UTC) #6
dgozman
lgtm https://codereview.chromium.org/2733493002/diff/40001/third_party/WebKit/LayoutTests/inspector/help/release-note.html File third_party/WebKit/LayoutTests/inspector/help/release-note.html (right): https://codereview.chromium.org/2733493002/diff/40001/third_party/WebKit/LayoutTests/inspector/help/release-note.html#newcode41 third_party/WebKit/LayoutTests/inspector/help/release-note.html:41: InspectorTest.addSniffer(UI.viewManager, "showView", onShowView); sniffer :-(
3 years, 9 months ago (2017-03-13 21:23:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733493002/40001
3 years, 9 months ago (2017-03-13 22:11:35 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:20:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/345a7614774506af8d576a396b4b...

Powered by Google App Engine
This is Rietveld 408576698