Chromium Code Reviews Chromium Code Reviews
Issue 2733493002:
DevTools: fix bug with persisting drawer selection (Closed)
| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="../../http/tests/inspector/inspector-test.js"></script> | 3 <script src="../../http/tests/inspector/inspector-test.js"></script> |
| 4 <script> | 4 <script> |
| 5 function test() { | 5 function test() { |
| 6 Help.releaseNoteText = [ | 6 Help.releaseNoteText = [ |
| 7 { | 7 { |
| 8 version: 99, | 8 version: 99, |
| 9 highlights: [ | 9 highlights: [ |
| 10 { | 10 { |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 31 ], | 31 ], |
| 32 }, | 32 }, |
| 33 ], | 33 ], |
| 34 link: 'https://developers.google.com/web/tools/chrome-devtools/', | 34 link: 'https://developers.google.com/web/tools/chrome-devtools/', |
| 35 image: { | 35 image: { |
| 36 src: './resources/test.png', | 36 src: './resources/test.png', |
| 37 }, | 37 }, |
| 38 }, | 38 }, |
| 39 ]; | 39 ]; |
| 40 | 40 |
| 41 InspectorTest.addSniffer(UI.inspectorView, "showPanel", onPanelShown); | 41 InspectorTest.addSniffer(UI.viewManager, "showView", onShowView); |
|
dgozman
2017/03/13 21:23:31
sniffer :-(
| |
| 42 | 42 |
| 43 InspectorTest.addResult(`Browser version: ${Help.browserVersion()}\n`); | 43 InspectorTest.addResult(`Browser version: ${Help.browserVersion()}\n`); |
| 44 Help.showReleaseNoteIfNeeded(); | 44 Help.showReleaseNoteIfNeeded(); |
| 45 | 45 |
| 46 function onPanelShown(viewId, panelPromise) { | 46 function onShowView(viewId, isUserGesture, viewPromise) { |
| 47 panelPromise.then(() => { | 47 viewPromise.then(() => { |
| 48 var releaseNoteView = UI.viewManager.view("release-note"); | 48 var releaseNoteView = UI.viewManager.view("release-note"); |
| 49 var releaseNoteElement = releaseNoteView[UI.View._widgetSymbol].cont entElement; | 49 var releaseNoteElement = releaseNoteView[UI.View._widgetSymbol].cont entElement; |
| 50 InspectorTest.addResult("Dumping release note text:"); | 50 InspectorTest.addResult("Dumping release note text:"); |
| 51 InspectorTest.addResult(releaseNoteElement.innerText); | 51 InspectorTest.addResult(releaseNoteElement.innerText); |
| 52 InspectorTest.addResult("Last version of release note seen should be updated:"); | 52 InspectorTest.addResult("Last version of release note seen should be updated:"); |
| 53 InspectorTest.addResult(Help.releaseNoteVersionSetting().get() + "\n "); | 53 InspectorTest.addResult(Help.releaseNoteVersionSetting().get() + "\n "); |
| 54 | 54 |
| 55 InspectorTest.addSniffer(UI.InspectorView.prototype, "closeDrawerTab ", onClose); | 55 InspectorTest.addSniffer(UI.InspectorView.prototype, "closeDrawerTab ", onClose); |
| 56 InspectorTest.addResult("Click on hide button"); | 56 InspectorTest.addResult("Click on hide button"); |
| 57 var closeButton = releaseNoteElement.querySelector(".close-release-n ote"); | 57 var closeButton = releaseNoteElement.querySelector(".close-release-n ote"); |
| 58 closeButton.click(); | 58 closeButton.click(); |
| 59 }); | 59 }); |
| 60 } | 60 } |
| 61 | 61 |
| 62 function onClose(view) { | 62 function onClose(view) { |
| 63 InspectorTest.addResult(`Hiding view: ${view}`); | 63 InspectorTest.addResult(`Hiding view: ${view}`); |
| 64 InspectorTest.completeTest(); | 64 InspectorTest.completeTest(); |
| 65 } | 65 } |
| 66 } | 66 } |
| 67 | 67 |
| 68 </script> | 68 </script> |
| 69 </head> | 69 </head> |
| 70 <body onload="runTest()"> | 70 <body onload="runTest()"> |
| 71 <p> | 71 <p> |
| 72 Test release note | 72 Test release note |
| 73 </p> | 73 </p> |
| 74 | 74 |
| 75 </body> | 75 </body> |
| 76 </html> | 76 </html> |
| OLD | NEW |
