third_party/WebKit/LayoutTests/inspector/help/release-note-unit.html - Issue 2733493002: DevTools: fix bug with persisting drawer selection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/help/release-note-unit.html

Issue 2733493002: DevTools: fix bug with persisting drawer selection (Closed)

Patch Set: fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/inspector/help/release-note.html ('K') | « third_party/WebKit/LayoutTests/inspector/help/release-note.html ('k') | third_party/WebKit/Source/devtools/front_end/help/Help.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script>	4 <script>

5 function test()	5 function test()

6 {	6 {

7 Help.releaseNoteText = [	7 Help.releaseNoteText = [

8 {version: 3},	8 {version: 3},

9 {version: 4},	9 {version: 4},

10 {version: 5},	10 {version: 5},

11 ];	11 ];

12	12

13 function testMaybeShowInDrawer(lastSeenVersion, browserVersion) {	13 function testMaybeShowInDrawer(lastSeenVersion, browserVersion) {

14 Help._latestReleaseNote = Help._getReleaseNoteByVersion(browserVersion);	14 Help._latestReleaseNote = Help._getReleaseNoteByVersion(browserVersion);

15 InspectorTest.addResult(`Last seen version: ${lastSeenVersion}`);	15 InspectorTest.addResult(`Last seen version: ${lastSeenVersion}`);

16 InspectorTest.addResult(`Browser version: ${browserVersion}`);	16 InspectorTest.addResult(`Browser version: ${browserVersion}`);

17 InspectorTest.addSniffer(UI.inspectorView, "showPanel", onPanelShown);	17 InspectorTest.addSniffer(UI.viewManager, "showView", onShowView);

18 var showedReleaseNote = false;	18 var showedReleaseNote = false;

19	19

20 Help._showReleaseNoteIfNeeded(lastSeenVersion, browserVersion);	20 Help._showReleaseNoteIfNeeded(lastSeenVersion, browserVersion);

21	21

22 function onPanelShown() {	22 function onShowView() {

23 showedReleaseNote = true;	23 showedReleaseNote = true;

24 }	24 }

25 if (showedReleaseNote)	25 if (showedReleaseNote)

26 InspectorTest.addResult(`Showed release note in drawer - version: ${ Help.latestReleaseNote().version}`);	26 InspectorTest.addResult(`Showed release note in drawer - version: ${ Help.latestReleaseNote().version}`);

27 else	27 else

28 InspectorTest.addResult('Did not show release note drawer');	28 InspectorTest.addResult('Did not show release note drawer');

29 }	29 }

30	30

31 function testGetReleaseNoteByVersion(version) {	31 function testGetReleaseNoteByVersion(version) {

32 InspectorTest.addResult(`Getting release note for browser version: ${ver sion}`);	32 InspectorTest.addResult(`Getting release note for browser version: ${ver sion}`);

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84 ]);	84 ]);

85 }	85 }

86 </script>	86 </script>

87 </head>	87 </head>

88 <body onload="runTest()">	88 <body onload="runTest()">

89 <p>	89 <p>

90 Unit test for release note	90 Unit test for release note

91 </p>	91 </p>

92 </body>	92 </body>

93 </html>	93 </html>

OLD	NEW