Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection

Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection

This patch makes |TypingCommand::insertText()| to take |SelectionInDOMTree|
instead of |VisibleSelection| to reduce usage of |VisibleSelection| for
improving code health.

BUG=657237
TEST=n/a

Review-Url: https://codereview.chromium.org/2733183002
Cr-Commit-Position: refs/heads/master@{#455368}
Committed: https://chromium.googlesource.com/chromium/src/+/a69c7b5d863dacbb08bfaa04359e3bc0bb4470dc

[yosin_UTC9, 2017-03-07 05:20:04]

Description was changed from

==========
2017-03-07T14:18:09

2017-03-07T14:17:46

BUG=
==========

to

==========
Make TypingCommand::insertText() to take SelectionInDOMTree instead of
VisibleSelection

This patch makes |TypingCommand::insertText()| to take |SelectionInDOMTree|
instead of |VisibleSelection| to reduce usage of |VisibleSelection| for
improving code health.

BUG=657237
TEST=n/a
==========

[yosin_UTC9, 2017-03-07 05:20:14]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 05:21:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-07 08:04:11]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-07 08:04:11]

PTAL

[commit-bot: I haz the power, 2017-03-07 08:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:08:27]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xiaocheng, 2017-03-07 18:56:01]

lgtm with a nit

https://codereview.chromium.org/2733183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp (right):

https://codereview.chromium.org/2733183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:293: // FIXME:
We shouldn't need to take selectionForInsertion. It should be
nit: s/selectionForInsertion/passedSelectionForInsertion/

[yosin_UTC9, 2017-03-08 00:58:36]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:19:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488934716278950, "parent_rev":
"54237ca8c36a7cebf34d07c467ace33b5d7ff1e9", "commit_rev":
"a69c7b5d863dacbb08bfaa04359e3bc0bb4470dc"}

[commit-bot: I haz the power, 2017-03-08 03:21:20]

Description was changed from

==========
Make TypingCommand::insertText() to take SelectionInDOMTree instead of
VisibleSelection

This patch makes |TypingCommand::insertText()| to take |SelectionInDOMTree|
instead of |VisibleSelection| to reduce usage of |VisibleSelection| for
improving code health.

BUG=657237
TEST=n/a
==========

to

==========
Make TypingCommand::insertText() to take SelectionInDOMTree instead of
VisibleSelection

This patch makes |TypingCommand::insertText()| to take |SelectionInDOMTree|
instead of |VisibleSelection| to reduce usage of |VisibleSelection| for
improving code health.

BUG=657237
TEST=n/a

Review-Url: https://codereview.chromium.org/2733183002
Cr-Commit-Position: refs/heads/master@{#455368}
Committed:
https://chromium.googlesource.com/chromium/src/+/a69c7b5d863dacbb08bfaa04359e...
==========

[commit-bot: I haz the power, 2017-03-08 03:21:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a69c7b5d863dacbb08bfaa04359e...