third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2733183002: Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2733183002: Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection (Closed)

Patch Set: 2017-03-07T14:18:09 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 3ce9536e6f79cd350201cd31130bd3514849f93c..dc47efd8ba5de94aedce338eb717bc2c56357366 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1026,7 +1026,7 @@ bool Editor::insertTextWithoutSendingTextEvent(const String& text,

// Insert the text

TypingCommand::insertText(

- *selection.start().document(), text, selection,

+ *selection.start().document(), text, selection.asSelection(),

selectInsertedText ? TypingCommand::SelectInsertedText : 0,

triggeringEvent && triggeringEvent->isComposition()

? TypingCommand::TextCompositionConfirm