third_party/WebKit/Source/core/editing/commands/TypingCommand.h - Issue 2733183002: Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2733183002: Make TypingCommand::insertText() to take SelectionInDOMTree instead of VisibleSelection (Closed)

Patch Set: 2017-03-07T14:18:09 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

index 7a52aa8e667ac4f7effa930e1032ec2b29425124..2955430895d1e00bb15d17427485f7c4e191e197 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h

@@ -73,7 +73,7 @@ class CORE_EXPORT TypingCommand final : public CompositeEditCommand {

const bool isIncrementalInsertion = false);

static void insertText(Document&,

const String&,

- const VisibleSelection&,

+ const SelectionInDOMTree&,

Options,

TextCompositionType = TextCompositionNone,

const bool isIncrementalInsertion = false);