Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2733103002: Adjust HTML VKB positioning. (Closed)

Created:
3 years, 9 months ago by cjgrant
Modified:
3 years, 9 months ago
Reviewers:
asimjour1, mthiesse, tiborg
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org, mthiesse
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust HTML VKB positioning. - Keep the VKB from moving into the floor when not active. - Show the keyboard only in Menu mode. - Instead of moving the VK, for now, fade and shrink it when not active. - Rename 'uiElementId' to 'id' for convenient. BUG=695898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2733103002 Cr-Commit-Position: refs/heads/master@{#455135} Committed: https://chromium.googlesource.com/chromium/src/+/a4fe824eb02d34107126ae84afe2edaff7c3c3c8

Patch Set 1 #

Patch Set 2 : Fix search-and-replace typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 17 chunks +46 lines, -38 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
cjgrant
3 years, 9 months ago (2017-03-06 22:26:35 UTC) #3
asimjour1
On 2017/03/06 22:26:35, cjgrant wrote: lgtm
3 years, 9 months ago (2017-03-07 13:20:45 UTC) #4
mthiesse
lgtm
3 years, 9 months ago (2017-03-07 15:18:51 UTC) #6
tiborg
lgtm
3 years, 9 months ago (2017-03-07 15:38:57 UTC) #7
tiborg
lgtm
3 years, 9 months ago (2017-03-07 15:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733103002/1
3 years, 9 months ago (2017-03-07 16:17:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733103002/20001
3 years, 9 months ago (2017-03-07 16:30:32 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:13:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4fe824eb02d34107126ae84afe2...

Powered by Google App Engine
This is Rietveld 408576698