Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2736083002: Suppress the Android keyboard when selecting VR UI input fields. (Closed)

Created:
3 years, 9 months ago by cjgrant
Modified:
3 years, 9 months ago
Reviewers:
mthiesse, asimjour1
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress the Android keyboard when selecting VR UI input fields. We already suppress the keyboard for the main WebContents; we need to do it for the UI WebContents as well. BUG=695898 Review-Url: https://codereview.chromium.org/2736083002 Cr-Commit-Position: refs/heads/master@{#455252} Committed: https://chromium.googlesource.com/chromium/src/+/b97438c4d7c950609a938cef8e791e2d8955d17f

Patch Set 1 #

Patch Set 2 : Reorder class forward declarations. #

Total comments: 3

Patch Set 3 : Remove duplicate WebContentsObserver. Nice! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
cjgrant
3 years, 9 months ago (2017-03-07 19:49:56 UTC) #2
cjgrant
https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode66 chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver : public content::WebContentsObserver { This class could ...
3 years, 9 months ago (2017-03-07 20:34:47 UTC) #3
mthiesse
https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode66 chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver : public content::WebContentsObserver { On 2017/03/07 20:34:47, ...
3 years, 9 months ago (2017-03-07 20:49:24 UTC) #4
cjgrant
https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/vr_shell/vr_shell.cc#newcode66 chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver : public content::WebContentsObserver { On 2017/03/07 20:49:24, ...
3 years, 9 months ago (2017-03-07 21:08:46 UTC) #5
mthiesse
lgtm
3 years, 9 months ago (2017-03-07 21:33:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736083002/40001
3 years, 9 months ago (2017-03-07 21:35:12 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 22:25:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b97438c4d7c950609a938cef8e79...

Powered by Google App Engine
This is Rietveld 408576698