Suppress the Android keyboard when selecting VR UI input fields.

Suppress the Android keyboard when selecting VR UI input fields.

We already suppress the keyboard for the main WebContents; we need to do
it for the UI WebContents as well.

BUG=695898
Review-Url: https://codereview.chromium.org/2736083002
Cr-Commit-Position: refs/heads/master@{#455252}
Committed: https://chromium.googlesource.com/chromium/src/+/b97438c4d7c950609a938cef8e791e2d8955d17f

[cjgrant, 2017-03-07 19:49:55]

cjgrant@chromium.org changed reviewers:
+ asimjour@chromium.org, mthiesse@chromium.org

[cjgrant, 2017-03-07 20:34:47]

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver :
public content::WebContentsObserver {
This class could live in a separate file, but given its size, I started it here.
 Happy to move it out if you guys prefer.

[mthiesse, 2017-03-07 20:49:24]

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver :
public content::WebContentsObserver {
On 2017/03/07 20:34:47, cjgrant wrote:
> This class could live in a separate file, but given its size, I started it
here.
>  Happy to move it out if you guys prefer.

VrShell is already an observer of the UI web contents. Please either re-use
that, or merge that one into this one.

[cjgrant, 2017-03-07 21:08:46]

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2736083002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:66: class UiWebContentsObserver :
public content::WebContentsObserver {
On 2017/03/07 20:49:24, mthiesse wrote:
> On 2017/03/07 20:34:47, cjgrant wrote:
> > This class could live in a separate file, but given its size, I started it
> here.
> >  Happy to move it out if you guys prefer.
> 
> VrShell is already an observer of the UI web contents. Please either re-use
> that, or merge that one into this one.

Done.  Wow, need to check eyes.

[mthiesse, 2017-03-07 21:33:47]

lgtm

[cjgrant, 2017-03-07 21:34:36]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:24:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488922476280110,
"parent_rev": "8bf474227977d380910fd4e9f5c00c269ccc6a09", "commit_rev":
"b97438c4d7c950609a938cef8e791e2d8955d17f"}

[commit-bot: I haz the power, 2017-03-07 22:25:17]

Description was changed from

==========
Suppress the Android keyboard when selecting VR UI input fields.

We already suppress the keyboard for the main WebContents; we need to do
it for the UI WebContents as well.

BUG=695898
==========

to

==========
Suppress the Android keyboard when selecting VR UI input fields.

We already suppress the keyboard for the main WebContents; we need to do
it for the UI WebContents as well.

BUG=695898

Review-Url: https://codereview.chromium.org/2736083002
Cr-Commit-Position: refs/heads/master@{#455252}
Committed:
https://chromium.googlesource.com/chromium/src/+/b97438c4d7c950609a938cef8e79...
==========

[commit-bot: I haz the power, 2017-03-07 22:25:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b97438c4d7c950609a938cef8e79...