Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2735693006: Connect virtual keyboard to omnibox (Closed)

Created:
3 years, 9 months ago by cjgrant
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org, tiborg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Connect virtual keyboard to omnibox - When keyboard input events are generated, select the UI omnibox input field. This special case may live until we switch to a different keyboard implementation. - Move the content quad back in menu mode, as elements behind the content quad are not hittable. BUG=695898 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2735693006 Cr-Commit-Position: refs/heads/master@{#455275} Committed: https://chromium.googlesource.com/chromium/src/+/40128da8b2ed5bdf0a4e84c86b6fc03b2541718e

Patch Set 1 #

Patch Set 2 : Rebase to master. #

Patch Set 3 : Rebase attempt 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/resources/vr_shell/vk.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 2 chunks +6 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (10 generated)
cjgrant
3 years, 9 months ago (2017-03-07 20:38:15 UTC) #4
asimjour
On 2017/03/07 20:38:15, cjgrant wrote: lgtm
3 years, 9 months ago (2017-03-07 20:43:31 UTC) #5
mthiesse
3 years, 9 months ago (2017-03-07 20:46:03 UTC) #6
mthiesse
lgtm
3 years, 9 months ago (2017-03-07 20:46:04 UTC) #7
tiborg
lgtm
3 years, 9 months ago (2017-03-07 20:50:28 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2736083002 Patch 20001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-07 21:10:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735693006/40001
3 years, 9 months ago (2017-03-07 21:46:18 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:09:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/40128da8b2ed5bdf0a4e84c86b6f...

Powered by Google App Engine
This is Rietveld 408576698