Use shared matchers for common elements.

Use shared matchers for common elements.

Add new matcher for OpenLinkInNewTabMenuItem(), and make all tests
use this. Also remove tests that have methods to match the stack
view button, and use the existing shared matcher ShowOpenTabs().

BUG=698774, 638674
Review-Url: https://codereview.chromium.org/2732973003
Cr-Commit-Position: refs/heads/master@{#454957}
Committed: https://chromium.googlesource.com/chromium/src/+/17581175d5df6d58e62d9e3e7b699df99dca1b19

[baxley, 2017-03-06 19:40:28]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-06 20:10:04]

Thank you for cleanup. lgtm

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/context_...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/context_...
ios/chrome/browser/context_menu/context_menu_egtest.mm:178:
chrome_test_util::OpenLinkInNewTabMenuItem());
Optional nit: do you want to add using
chrome_test_util::OpenLinkInNewTabMenuItem to improve formatting?

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/ui/histo...
File ios/chrome/browser/ui/history/history_ui_egtest.mm (right):

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/ui/histo...
ios/chrome/browser/ui/history/history_ui_egtest.mm:430:
selectElementWithMatcher:chrome_test_util::OpenLinkInNewTabMenuItem()]
ditto

[baxley, 2017-03-06 20:53:35]

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/context_...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/context_...
ios/chrome/browser/context_menu/context_menu_egtest.mm:178:
chrome_test_util::OpenLinkInNewTabMenuItem());
On 2017/03/06 20:10:04, Eugene But wrote:
> Optional nit: do you want to add using
> chrome_test_util::OpenLinkInNewTabMenuItem to improve formatting?

I left it as is, since the using makes it more than 80 chars, and doesn't help a
ton.

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/ui/histo...
File ios/chrome/browser/ui/history/history_ui_egtest.mm (right):

https://codereview.chromium.org/2732973003/diff/1/ios/chrome/browser/ui/histo...
ios/chrome/browser/ui/history/history_ui_egtest.mm:430:
selectElementWithMatcher:chrome_test_util::OpenLinkInNewTabMenuItem()]
On 2017/03/06 20:10:04, Eugene But wrote:
> ditto

Done.

[baxley, 2017-03-06 20:53:40]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-06 20:53:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2732973003/#ps20001
(title: "clean up format with using")

[commit-bot: I haz the power, 2017-03-06 20:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 21:14:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488833620085070,
"parent_rev": "517b840ba9cf91c4a33bd3c0552b74bf4b2a64e9", "commit_rev":
"17581175d5df6d58e62d9e3e7b699df99dca1b19"}

[commit-bot: I haz the power, 2017-03-06 21:15:15]

Description was changed from

==========
Use shared matchers for common elements.

Add new matcher for OpenLinkInNewTabMenuItem(), and make all tests
use this. Also remove tests that have methods to match the stack
view button, and use the existing shared matcher ShowOpenTabs().

BUG=698774,638674
==========

to

==========
Use shared matchers for common elements.

Add new matcher for OpenLinkInNewTabMenuItem(), and make all tests
use this. Also remove tests that have methods to match the stack
view button, and use the existing shared matcher ShowOpenTabs().

BUG=698774,638674

Review-Url: https://codereview.chromium.org/2732973003
Cr-Commit-Position: refs/heads/master@{#454957}
Committed:
https://chromium.googlesource.com/chromium/src/+/17581175d5df6d58e62d9e3e7b69...
==========

[commit-bot: I haz the power, 2017-03-06 21:15:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17581175d5df6d58e62d9e3e7b69...