Use shared matchers for common elements.

ios/chrome/browser/context_menu/context_menu_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "ios/chrome/browser/ui/ui_util.h"
@@ skipping 38 matching lines @@
 id<GREYMatcher> OpenImageButton() {
   return ButtonWithAccessibilityLabelId(IDS_IOS_CONTENT_CONTEXT_OPENIMAGE);
 }
 
 // Matcher for the open image in new tab button in the context menu.
 id<GREYMatcher> OpenImageInNewTabButton() {
   return ButtonWithAccessibilityLabelId(
       IDS_IOS_CONTENT_CONTEXT_OPENIMAGENEWTAB);
 }
 
-// Matcher for the open link in new tab button in the context menu.
-// TODO(crbug.com/638674): Clean up code duplication.
-id<GREYMatcher> OpenLinkInNewTabButton() {
-  return ButtonWithAccessibilityLabelId(IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB);
-}
-
 // Waits for the context menu item to disappear. TODO(crbug.com/682871): Remove
 // this once EarlGrey is synchronized with context menu.
 void WaitForContextMenuItemDisappeared(id<GREYMatcher> contextMenuItemButton) {
   ConditionBlock condition = ^{
     NSError* error = nil;
     [[EarlGrey selectElementWithMatcher:contextMenuItemButton]
         assertWithMatcher:grey_nil()
                     error:&error];
     return error == nil;
   };
@@ skipping 98 matching lines @@
 
   // The initial page contains a link to the destination page.
   responses[initialURL] = "<a style='margin-left:50px' href='" +
                           destinationURL.spec() + "' id='link'>link</a>";
   responses[destinationURL] = kDestinationHtml;
 
   web::test::SetUpSimpleHttpServer(responses);
   [ChromeEarlGrey loadURL:initialURL];
   chrome_test_util::AssertMainTabCount(1U);
 
-  LongPressElementAndTapOnButton(kDestinationLinkID, OpenLinkInNewTabButton());
+  LongPressElementAndTapOnButton(kDestinationLinkID,
+                                 chrome_test_util::OpenLinkInNewTabMenuItem());

[Eugene But (OOO till 7-30), 2017/03/06 20:10:04]

Optional nit: do you want to add using
chrome_test_util::OpenLinkInNewTabMenuItem to improve formatting?

[baxley, 2017/03/06 20:53:34]

I left it as is, since the using makes it more than 80 chars, and doesn't help a
ton.

 
   SelectTabAtIndexInCurrentMode(1U);
 
   // Verify url and tab count.
   [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
                                           destinationURL.GetContent())]
       assertWithMatcher:grey_notNil()];
   chrome_test_util::AssertMainTabCount(2U);
 }
 
@@ skipping 21 matching lines @@
 
   // Scroll down on the web view to make the link visible.
   [[EarlGrey
       selectElementWithMatcher:WebViewScrollView(
                                    chrome_test_util::GetCurrentWebState())]
       performAction:grey_swipeFastInDirection(kGREYDirectionUp)];
   [[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewContainingText(
                                           kDestinationLinkID)]
       assertWithMatcher:grey_notNil()];
 
-  LongPressElementAndTapOnButton(kDestinationLinkID, OpenLinkInNewTabButton());
+  LongPressElementAndTapOnButton(kDestinationLinkID,
+                                 chrome_test_util::OpenLinkInNewTabMenuItem());
 
   // Earl Grey cannot preperly synchronize some animations, so adding a
   // WaitUntilCondition to wait for the new tab opening animation to finish
   // and the scroll view to become interactable.
   ConditionBlock condition = ^{
     NSError* error = nil;
     [[EarlGrey
         selectElementWithMatcher:WebViewScrollView(
                                      chrome_test_util::GetCurrentWebState())]
         assertWithMatcher:grey_interactable()
@@ skipping 15 matching lines @@
   SelectTabAtIndexInCurrentMode(1U);
 
   // Verify url and tab count.
   [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
                                           destinationURL.GetContent())]
       assertWithMatcher:grey_notNil()];
   chrome_test_util::AssertMainTabCount(2U);
 }
 
 @end