Use shared matchers for common elements.

ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <XCTest/XCTest.h>
 
 #include "base/mac/bind_objc_block.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
@@ skipping 161 matching lines @@
     // Select the non incognito panel.
     id<GREYMatcher> tabSwitcherHeaderPanelButton =
         grey_accessibilityLabel(l10n_util::GetNSStringWithFixup(
             IDS_IOS_TAB_SWITCHER_HEADER_NON_INCOGNITO_TABS));
     [[EarlGrey selectElementWithMatcher:tabSwitcherHeaderPanelButton]
         performAction:grey_tap()];
 
     // Leave the tab switcher.
     CloseTabSwitcher();
   } else {
-    [[EarlGrey selectElementWithMatcher:
-                   chrome_test_util::ButtonWithAccessibilityLabelId(
-                       IDS_IOS_TOOLBAR_SHOW_TABS)] performAction:grey_tap()];
+    [[EarlGrey selectElementWithMatcher:chrome_test_util::ShowTabsButton()]
+        performAction:grey_tap()];
     [[EarlGrey selectElementWithMatcher:
                    chrome_test_util::ButtonWithAccessibilityLabelId(
                        IDS_IOS_TOOLS_MENU_NEW_INCOGNITO_TAB)]
         performAction:grey_swipeSlowInDirection(kGREYDirectionRight)];
-    [[EarlGrey selectElementWithMatcher:
-                   chrome_test_util::ButtonWithAccessibilityLabelId(
-                       IDS_IOS_TOOLBAR_SHOW_TABS)] performAction:grey_tap()];
+    [[EarlGrey selectElementWithMatcher:chrome_test_util::ShowTabsButton()]
+        performAction:grey_tap()];
   }
   ConditionBlock condition = ^bool {
     return !chrome_test_util::IsIncognitoMode();
   };
   GREYAssert(
       testing::WaitUntilConditionOrTimeout(kWaitElementTimeout, condition),
       @"Waiting switch to normal mode.");
 }
 
 // Check that the error page is visible.
@@ skipping 26 matching lines @@
       grey_accessibilityID(kToolsMenuSettingsId);
 
   WaitAndTap(settings_button_matcher, @"Settings menu");
   Wait(grey_accessibilityID(kSettingsCollectionViewId), @"Setting view");
 }
 
 // Select the tab with title |title| using UI (tab strip on iPad, stack view on
 // iPhone).
 void SelectTabUsingUI(NSString* title) {
   if (IsCompact()) {
-    WaitAndTap(chrome_test_util::ButtonWithAccessibilityLabelId(
-                   IDS_IOS_TOOLBAR_SHOW_TABS),
-               @"Tab switcher");
+    WaitAndTap(chrome_test_util::ShowTabsButton(), @"Tab switcher");
   }
   WaitAndTap(grey_text(title),
              [NSString stringWithFormat:@"tab with title %@", title]);
 }
 }  // namespace
 
 // Test for the TabUsageRecorder class.
 @interface TabUsageRecorderTestCase : ChromeTestCase
 @end
 
@@ skipping 602 matching lines @@
 
   // Open a tab with a link to click.
   NewMainTabWithURL(initialURL, "link");
 
   int numberOfTabs = chrome_test_util::GetMainTabCount();
   [[EarlGrey
       selectElementWithMatcher:chrome_test_util::WebViewContainingText("link")]
       performAction:grey_longPress()];
 
   [[EarlGrey
-      selectElementWithMatcher:grey_text(l10n_util::GetNSString(
-                                   IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB))]
+      selectElementWithMatcher:chrome_test_util::OpenLinkInNewTabMenuItem()]
       performAction:grey_tap()];
   chrome_test_util::AssertMainTabCount(numberOfTabs + 1);
 
   SelectTabUsingUI(base::SysUTF8ToNSString(destinationURL.GetContent()));
 
   [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   [[EarlGrey
       selectElementWithMatcher:chrome_test_util::WebViewContainingText("Whee")]
       assertWithMatcher:grey_notNil()];
 
@@ skipping 69 matching lines @@
     [[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
   }
   // The deleted tabs are purged during foregrounding and backgrounding.
   chrome_test_util::SimulateTabsBackgrounding();
   // Make sure |evicted_tabs_| purged the deleted tabs.
   int evicted = chrome_test_util::GetEvictedMainTabCount();
   GREYAssertEqual(evicted, 0, @"Check number of evicted tabs");
 }
 
 @end