DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped probes.

DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped probes.

BUG=695625
Review-Url: https://codereview.chromium.org/2732643003
Cr-Commit-Position: refs/heads/master@{#454993}
Committed: https://chromium.googlesource.com/chromium/src/+/ca679a17b68dbc0b26a088bc099b8ff918a37e00

[pfeldman, 2017-03-03 23:41:42]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org

[pfeldman, 2017-03-04 00:18:10]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 00:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-03-04 00:20:59]

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.h (right):

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.h:137: const void*
m_userCallback;
File a bug and add a FIXME on why this is so?

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
(right):

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h:53: double
startTime() const;
lazyStartTime() & lazyEndTime()?

[pfeldman, 2017-03-04 00:26:23]

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
(right):

https://codereview.chromium.org/2732643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h:53: double
startTime() const;
On 2017/03/04 00:20:59, caseq wrote:
> lazyStartTime() & lazyEndTime()?

I actually find it misleading - you are in fact forcing capture most of the time
and it should be obvious.

[pfeldman, 2017-03-04 00:27:30]

Patchset #4 (id:60001) has been deleted

[caseq, 2017-03-04 00:27:35]

https://codereview.chromium.org/2732643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2732643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:225: if
(--m_userCallbackDepth)
!--m_userCallbackDepth

[pfeldman, 2017-03-04 00:31:59]

Patchset #4 (id:80001) has been deleted

[pfeldman, 2017-03-04 00:32:25]

https://codereview.chromium.org/2732643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2732643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:225: if
(--m_userCallbackDepth)
On 2017/03/04 00:27:34, caseq wrote:
> !--m_userCallbackDepth

Yup. Already fixed, thanks.

[caseq, 2017-03-04 00:48:20]

lgtm

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:214: m_userCallback
= &probe;
DCHECK(!m_userCallback) above that?

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:244:
m_userCallbackDepth = 0;
Let's not do this one, otherwise they may get negative.

[alph, 2017-03-04 02:09:11]

lgtm

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:144: if
(m_thresholds[kLongLayout] && m_scriptDepth)
nit: merge with m_enabled to match the condition in 'did'

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:168:
m_perTaskStyleAndLayoutTime += probe.duration();
nit: you can just make duration return 0 when capture not initiated. Otherwise
it's difficult to keep conditions in sync.

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
(right):

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h:49: class
ProbeBase {
CORE_EXPORT

[pfeldman, 2017-03-04 02:37:08]

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right):

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:168:
m_perTaskStyleAndLayoutTime += probe.duration();
On 2017/03/04 02:09:10, alph wrote:
> nit: you can just make duration return 0 when capture not initiated. Otherwise
> it's difficult to keep conditions in sync.

But that way I loose all the bugs.

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:214: m_userCallback
= &probe;
On 2017/03/04 00:48:20, caseq wrote:
> DCHECK(!m_userCallback) above that?

Done.

https://codereview.chromium.org/2732643003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:244:
m_userCallbackDepth = 0;
On 2017/03/04 00:48:19, caseq wrote:
> Let's not do this one, otherwise they may get negative.

Done.

[pfeldman, 2017-03-04 02:37:12]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-03-04 02:37:12]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2732643003/#ps120001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2017-03-04 02:37:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 03:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 03:14:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-03-06 19:28:12]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 19:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:24:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-03-06 21:39:01]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-03-06 21:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2732643003/#ps150001
(title: "Introduce progress monitor")

[commit-bot: I haz the power, 2017-03-06 21:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:18:24]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1488836341668150,
"parent_rev": "0712a2ecd73b028bb2e67ca7dfde62172ff593de", "commit_rev":
"ca679a17b68dbc0b26a088bc099b8ff918a37e00"}

[commit-bot: I haz the power, 2017-03-06 23:19:12]

Description was changed from

==========
DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped
probes.

BUG=695625
==========

to

==========
DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped
probes.

BUG=695625

Review-Url: https://codereview.chromium.org/2732643003
Cr-Commit-Position: refs/heads/master@{#454993}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca679a17b68dbc0b26a088bc099b...
==========

[commit-bot: I haz the power, 2017-03-06 23:19:14]

Committed patchset #7 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/ca679a17b68dbc0b26a088bc099b...