Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 2732643003: DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped probes. (Closed)
Patch Set: Introduce progress monitor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
index 7a4cea791a18431f36b886b78da096b4d1573f23..88bc277e1302386bd70ed7c93fab23e238f1586c 100755
--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
@@ -60,6 +60,7 @@ namespace blink {
${extra_definitions}
namespace probe {
+
$methods
} // namespace probe
@@ -67,7 +68,7 @@ $methods
""")
template_scoped_decl = string.Template("""
-class CORE_EXPORT ${name} {
+class CORE_EXPORT ${name} : public ProbeBase {
STACK_ALLOCATED()
public:
explicit $name($param_list);
@@ -416,7 +417,7 @@ def generate_param_name(param_type):
def generate_member_decl(param):
- if param.is_ptr:
+ if param.is_ptr and "char" not in param.type:
return " Member<%s> %s;" % (param.type[:-1], param.name)
else:
return " %s %s;" % (param.type, param.name)

Powered by Google App Engine
This is Rietveld 408576698