Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp

Issue 2732643003: DevTools: remove PerformanceMonitor::HandlerCall, migrate to the new scoped probes. (Closed)
Patch Set: Introduce progress monitor Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/FrameRequestCallbackCollection.h" 5 #include "core/dom/FrameRequestCallbackCollection.h"
6 6
7 #include "core/dom/FrameRequestCallback.h" 7 #include "core/dom/FrameRequestCallback.h"
8 #include "core/frame/PerformanceMonitor.h"
9 #include "core/inspector/InspectorInstrumentation.h" 8 #include "core/inspector/InspectorInstrumentation.h"
10 #include "core/inspector/InspectorTraceEvents.h" 9 #include "core/inspector/InspectorTraceEvents.h"
11 10
12 namespace blink { 11 namespace blink {
13 12
14 FrameRequestCallbackCollection::FrameRequestCallbackCollection( 13 FrameRequestCallbackCollection::FrameRequestCallbackCollection(
15 ExecutionContext* context) 14 ExecutionContext* context)
16 : m_context(context) {} 15 : m_context(context) {}
17 16
18 FrameRequestCallbackCollection::CallbackId 17 FrameRequestCallbackCollection::CallbackId
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 DCHECK(m_callbacksToInvoke.isEmpty()); 64 DCHECK(m_callbacksToInvoke.isEmpty());
66 m_callbacksToInvoke.swap(m_callbacks); 65 m_callbacksToInvoke.swap(m_callbacks);
67 66
68 for (const auto& callback : m_callbacksToInvoke) { 67 for (const auto& callback : m_callbacksToInvoke) {
69 if (!callback->m_cancelled) { 68 if (!callback->m_cancelled) {
70 TRACE_EVENT1( 69 TRACE_EVENT1(
71 "devtools.timeline", "FireAnimationFrame", "data", 70 "devtools.timeline", "FireAnimationFrame", "data",
72 InspectorAnimationFrameEvent::data(m_context, callback->m_id)); 71 InspectorAnimationFrameEvent::data(m_context, callback->m_id));
73 probe::AsyncTask asyncTask(m_context, callback, 72 probe::AsyncTask asyncTask(m_context, callback,
74 "requestAnimationFrame.callback"); 73 "requestAnimationFrame.callback");
75 PerformanceMonitor::HandlerCall handlerCall( 74 probe::UserCallback probe(m_context, "requestAnimationFrame",
76 m_context, "requestAnimationFrame", true); 75 AtomicString(), true);
77 if (callback->m_useLegacyTimeBase) 76 if (callback->m_useLegacyTimeBase)
78 callback->handleEvent(highResNowMsLegacy); 77 callback->handleEvent(highResNowMsLegacy);
79 else 78 else
80 callback->handleEvent(highResNowMs); 79 callback->handleEvent(highResNowMs);
81 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), 80 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"),
82 "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data", 81 "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data",
83 InspectorUpdateCountersEvent::data()); 82 InspectorUpdateCountersEvent::data());
84 } 83 }
85 } 84 }
86 85
87 m_callbacksToInvoke.clear(); 86 m_callbacksToInvoke.clear();
88 } 87 }
89 88
90 DEFINE_TRACE(FrameRequestCallbackCollection) { 89 DEFINE_TRACE(FrameRequestCallbackCollection) {
91 visitor->trace(m_callbacks); 90 visitor->trace(m_callbacks);
92 visitor->trace(m_callbacksToInvoke); 91 visitor->trace(m_callbacksToInvoke);
93 visitor->trace(m_context); 92 visitor->trace(m_context);
94 } 93 }
95 94
96 } // namespace blink 95 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698