Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2732573002: chromeos: moves more ash tests to run on mash (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: moves more ash tests to run on mash And pointers to bugs for those that aren't moved to common. BUG=631103, 633782, 634994, 648733, 695887, 696752, 696754, 698016, 698024, 698032, 698033, 698043, 698049, 698060, 698085, 698092, 698093, 698129 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2732573002 Cr-Commit-Position: refs/heads/master@{#454514} Committed: https://chromium.googlesource.com/chromium/src/+/eca38d4605fa46a7822ca5522db352415d97eed4

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix bug ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -30 lines) Patch
M ash/BUILD.gn View 2 chunks +36 lines, -13 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 5 chunks +10 lines, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 3 chunks +7 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 12 chunks +46 lines, -0 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 6 chunks +20 lines, -5 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 4 chunks +16 lines, -0 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sky
3 years, 9 months ago (2017-03-03 00:47:32 UTC) #1
msw
lgtm with a q https://codereview.chromium.org/2732573002/diff/1/ash/system/overview/overview_button_tray_unittest.cc File ash/system/overview/overview_button_tray_unittest.cc (right): https://codereview.chromium.org/2732573002/diff/1/ash/system/overview/overview_button_tray_unittest.cc#newcode114 ash/system/overview/overview_button_tray_unittest.cc:114: // TODO: investigate failure in ...
3 years, 9 months ago (2017-03-03 01:08:10 UTC) #4
sky
I also removed a couple of TODOs that are no longer relevant. https://codereview.chromium.org/2732573002/diff/1/ash/system/overview/overview_button_tray_unittest.cc File ash/system/overview/overview_button_tray_unittest.cc ...
3 years, 9 months ago (2017-03-03 03:51:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732573002/20001
3 years, 9 months ago (2017-03-03 03:51:22 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:23:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eca38d4605fa46a7822ca5522db3...

Powered by Google App Engine
This is Rietveld 408576698