Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: ash/wm/dock/docked_window_resizer_unittest.cc

Issue 2732573002: chromeos: moves more ash tests to run on mash (Closed)
Patch Set: fix bug ref Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/dock/docked_window_resizer_unittest.cc
diff --git a/ash/wm/dock/docked_window_resizer_unittest.cc b/ash/wm/dock/docked_window_resizer_unittest.cc
index 730d4784bd1a515225f5e765ab4aa6ad868dd81e..7cf458313cd61e08a8e194b6096b0ea0e824b8d1 100644
--- a/ash/wm/dock/docked_window_resizer_unittest.cc
+++ b/ash/wm/dock/docked_window_resizer_unittest.cc
@@ -95,13 +95,12 @@ class DockedWindowResizerTest
} else {
display::Display display =
display::Screen::GetScreen()->GetDisplayMatching(bounds);
- aura::Window* root = ash::Shell::GetInstance()
- ->window_tree_host_manager()
- ->GetRootWindowForDisplayId(display.id());
+ WmWindow* root = WmShell::Get()->GetRootWindowForDisplayId(display.id());
gfx::Point origin = bounds.origin();
- ::wm::ConvertPointFromScreen(root, &origin);
+ ::wm::ConvertPointFromScreen(root->aura_window(), &origin);
window->SetBounds(gfx::Rect(origin, bounds.size()));
- aura::client::ParentWindowWithContext(window, root, bounds);
+ aura::client::ParentWindowWithContext(window, root->aura_window(),
+ bounds);
}
return window;
}
@@ -653,6 +652,10 @@ TEST_P(DockedWindowResizerTest, RevertDockedDragRevertsAttachment) {
// Move a docked window to the second display
TEST_P(DockedWindowResizerTest, DragAcrossDisplays) {
+ // TODO: investigate failure in mash. http://crbug.com/698060.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
UpdateDisplay("800x800,800x800");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ(2, static_cast<int>(root_windows.size()));
@@ -1318,6 +1321,10 @@ TEST_P(DockedWindowResizerTest, DragToShelf) {
// Tests that docking and undocking a |window| with a transient child properly
// maintains the parent of that transient child to be the same as the |window|.
TEST_P(DockedWindowResizerTest, DragWindowWithTransientChild) {
+ // TODO: investigate failure in mash. http://crbug.com/698060.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
// Create a window with a transient child.
std::unique_ptr<aura::Window> window(
CreateTestWindow(gfx::Rect(0, 0, 201, 201)));
« no previous file with comments | « ash/wm/dock/docked_window_layout_manager_unittest.cc ('k') | ash/wm/immersive_fullscreen_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698