Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: ash/BUILD.gn

Issue 2732573002: chromeos: moves more ash tests to run on mash (Closed)
Patch Set: fix bug ref Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/focus_cycler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/BUILD.gn
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index b413405e4436336369f84c1200c6f7328029a405..307408ab1acd25c0d137be116cd19ae117fa3a2b 100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -1235,6 +1235,19 @@ source_set("common_unittests") {
"system/chromeos/power/power_event_observer_unittest.cc",
"system/chromeos/power/tablet_power_button_controller_unittest.cc",
"system/chromeos/power/video_activity_notifier_unittest.cc",
+ "system/overview/overview_button_tray_unittest.cc",
+ "system/toast/toast_manager_unittest.cc",
+ "system/web_notification/ash_popup_alignment_delegate_unittest.cc",
+ "system/web_notification/web_notification_tray_unittest.cc",
+ "test/ash_test_helper_unittest.cc",
+ "tooltips/tooltip_controller_unittest.cc",
+ "wm/ash_focus_rules_unittest.cc",
+ "wm/dock/docked_window_layout_manager_unittest.cc",
+ "wm/dock/docked_window_resizer_unittest.cc",
+ "wm/immersive_fullscreen_controller_unittest.cc",
+ "wm/lock_state_controller_unittest.cc",
+ "wm/maximize_mode/accelerometer_test_data_literals.cc",
+ "wm/maximize_mode/maximize_mode_window_manager_unittest.cc",
]
deps = [
"//ash",
@@ -1324,32 +1337,42 @@ test("ash_unittests") {
# TODO: investigate failure in mash, http://crbug.com/695887.
"system/chromeos/rotation/tray_rotation_lock_unittest.cc",
+
+ # TODO: fails as ScreenLayoutObserver is not installed in mash,
+ # http://crbug.com/696752.
"system/chromeos/screen_layout_observer_unittest.cc",
- "system/overview/overview_button_tray_unittest.cc",
- "system/toast/toast_manager_unittest.cc",
- "system/web_notification/ash_popup_alignment_delegate_unittest.cc",
- "system/web_notification/web_notification_tray_unittest.cc",
- "test/ash_test_helper_unittest.cc",
"test/ash_test_suite.cc",
"test/ash_test_suite.h",
"test/ash_unittests.cc",
- "tooltips/tooltip_controller_unittest.cc",
+
+ # TODO(riajiang): port to work with mash. http://crbug.com/698032.
"touch/touch_observer_hud_unittest.cc",
+
+ # TODO(moshayedi): port to work with mash. http://crbug.com/698033.
"utility/screenshot_controller_unittest.cc",
+
+ # TODO: keyboard is not enabled in mash. http://crbug.com/648733.
"virtual_keyboard_controller_unittest.cc",
+
+ # TODO: keyboard is not enabled in mash. http://crbug.com/648733.
"wm/always_on_top_controller_unittest.cc",
- "wm/ash_focus_rules_unittest.cc",
+
+ # TODO: mash doesn't support CursorManager. http://crbug.com/631103.
"wm/ash_native_cursor_manager_unittest.cc",
- "wm/dock/docked_window_layout_manager_unittest.cc",
- "wm/dock/docked_window_resizer_unittest.cc",
+
+ # TODO: mash doesn't support DragWindowResizer. http://crbug.com/633782.
"wm/drag_window_resizer_unittest.cc",
+
+ # TODO: mash doesn't support OverviewGestureHandler.
+ # http://crbug.com/634994.
"wm/gestures/overview_gesture_handler_unittest.cc",
- "wm/immersive_fullscreen_controller_unittest.cc",
+
+ # TODO: fails because keyboard is not enabled in mash.
+ # http://crbug.com/648733.
"wm/lock_layout_manager_unittest.cc",
- "wm/lock_state_controller_unittest.cc",
- "wm/maximize_mode/accelerometer_test_data_literals.cc",
+
+ # TODO: investigate failures in mash. http://crbug.com/698092.
"wm/maximize_mode/maximize_mode_controller_unittest.cc",
- "wm/maximize_mode/maximize_mode_window_manager_unittest.cc",
"wm/overlay_event_filter_unittest.cc",
"wm/overview/window_selector_unittest.cc",
"wm/panels/panel_layout_manager_unittest.cc",
« no previous file with comments | « no previous file | ash/focus_cycler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698