Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2732153002: Revert of Prepare WindowProxy for using v8::Context::NewRemoteContext(). (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prepare WindowProxy for using v8::Context::NewRemoteContext(). (patchset #6 id:100001 of https://codereview.chromium.org/2724573002/ ) Reason for revert: This is causing mysterious crashes. See https://crbug.com/696528 Original issue's description: > Prepare WindowProxy for using v8::Context::NewRemoteContext(). > > Currently, there is a lot of logic specific to v8::Context in > WindowProxy. Since it won't be used at all for the remote context > path, move the logic down into LocalWindowProxy/RemoteWindowProxy. > A followup CL will switch RemoteWindowProxy to use v8's remote > context API. > > BUG=527190 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2724573002 > Cr-Commit-Position: refs/heads/master@{#453572} > Committed: https://chromium.googlesource.com/chromium/src/+/1ffffb4de5e00f7cf4d45bb051715892ab621d18 R=haraken@chromium.org TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=527190 Review-Url: https://codereview.chromium.org/2732153002 . Cr-Commit-Position: refs/heads/master@{#455041} Committed: https://chromium.googlesource.com/chromium/src/+/d3f393cf3116d1f44b5a41b0e12165747f253c4c

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
dcheng
Created Revert of Prepare WindowProxy for using v8::Context::NewRemoteContext().
3 years, 9 months ago (2017-03-06 23:31:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732153002/1
3 years, 9 months ago (2017-03-06 23:31:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378885)
3 years, 9 months ago (2017-03-07 01:48:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732153002/1
3 years, 9 months ago (2017-03-07 03:18:33 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-07 03:27:13 UTC) #8
dcheng
3 years, 9 months ago (2017-03-07 06:04:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3f393cf3116d1f44b5a41b0e12165747f253c4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698