Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2732153002: Revert of Prepare WindowProxy for using v8::Context::NewRemoteContext(). (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
index 7e7fde4d558ba7f859856faf47a306013c66b1c4..6e6a394cf580647da90bcd15dc67c531c9f2e6e4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h
@@ -32,25 +32,12 @@
#define RemoteWindowProxy_h
#include "bindings/core/v8/DOMWrapperWorld.h"
-#include "bindings/core/v8/ScriptState.h"
-#include "bindings/core/v8/WindowProxy.h"
#include "core/frame/RemoteFrame.h"
#include "v8/include/v8.h"
-#include "wtf/RefPtr.h"
namespace blink {
// Subclass of WindowProxy that only handles RemoteFrame.
-// TODO(dcheng): This class currently duplicates a lot of logic from
-// LocalWindowPoxy:
-// - contextIfInitialized
-// - initialize
-// - disposeContext
-// - setupWindowPrototypeChain
-// - createContext
-// This is currently duplicated to make it easier to stage the switch to using
-// v8::RemoteContext::NewRemoteContext, and will be removed once the switch
-// is complete.
class RemoteWindowProxy final : public WindowProxy {
public:
static RemoteWindowProxy* create(v8::Isolate* isolate,
@@ -60,27 +47,17 @@
return new RemoteWindowProxy(isolate, frame, std::move(world));
}
- v8::Local<v8::Context> contextIfInitialized() const {
- return m_scriptState ? m_scriptState->context() : v8::Local<v8::Context>();
- }
-
private:
RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);
void initialize() override;
void disposeContext(GlobalDetachmentBehavior) override;
- // Associates the window wrapper and its prototype chain with the native
- // DOMWindow object. Also does some more Window-specific initialization.
- void setupWindowPrototypeChain();
-
// Creates a new v8::Context with the window wrapper object as the global
// object (aka the inner global). Note that the window wrapper and its
// prototype chain do not get fully initialized yet, e.g. the window
// wrapper is not yet associated with the native DOMWindow object.
void createContext();
-
- RefPtr<ScriptState> m_scriptState;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698