Prepare WindowProxy for using v8::Context::NewRemoteContext().

Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context
path, move the logic down into LocalWindowProxy/RemoteWindowProxy.
A followup CL will switch RemoteWindowProxy to use v8's remote
context API.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2724573002
Cr-Commit-Position: refs/heads/master@{#453572}
Committed: https://chromium.googlesource.com/chromium/src/+/1ffffb4de5e00f7cf4d45bb051715892ab621d18

[dcheng, 2017-02-28 09:03:46]

Description was changed from

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context path,
refactor and move it into LocalWindowProxy.

BUG=527190
==========

to

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context path,
refactor and move it into LocalWindowProxy.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dcheng, 2017-02-28 09:03:46]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2017-02-28 09:03:49]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 09:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-28 09:05:43]

Description was changed from

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context path,
refactor and move it into LocalWindowProxy.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context
path, move the logic down into LocalWindowProxy/RemoteWindowProxy.
A followup CL will switch RemoteWindowProxy to use v8's remote
context API.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dcheng, 2017-02-28 09:10:50]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 09:11:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-28 09:16:00]

I tried to land https://codereview.chromium.org/2626183003 over the weekend, and
it caused a big regression in canary: there's some code path where the internal
fields of the v8 objects aren't getting initialized for DOMWindow.

To try to narrow down what's going wrong, I'm trying to land
https://codereview.chromium.org/2626183003 without actually switching to use v8
remote context. This moves all the actual logic that deals with v8 into
{Local,Remote}WindowProxy. This way, I hope that breaking up the CLs this way
will make the patches easier to understand, while I work on figuring out where
the bug is.

[dcheng, 2017-02-28 09:17:13]

Oh, and PS3 is a rebased version of https://codereview.chromium.org/2720973002/
(which is the original CL for NewRemoteContext). So you can just diff PS3 and
PS4 to see what I removed.

[haraken, 2017-02-28 09:19:09]

LGTM

https://codereview.chromium.org/2724573002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp (right):

https://codereview.chromium.org/2724573002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp:115: void
RemoteWindowProxy::setupWindowPrototypeChain() {

Add a comment and mention why this is duplicated between LocalWindowProxy and
RemoteWindowProxy. And add a TODO to remove it once we have a remote context.

[dcheng, 2017-02-28 09:22:39]

https://codereview.chromium.org/2724573002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp (right):

https://codereview.chromium.org/2724573002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp:115: void
RemoteWindowProxy::setupWindowPrototypeChain() {
On 2017/02/28 09:19:09, haraken wrote:
> 
> Add a comment and mention why this is duplicated between LocalWindowProxy and
> RemoteWindowProxy. And add a TODO to remove it once we have a remote context.

I added the TODO to the header file.

[dcheng, 2017-02-28 09:22:41]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 09:22:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-28 09:54:20]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2017-02-28 09:54:21]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-02-28 09:54:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2724573002/#ps80001
(title: "Add TODO")

[commit-bot: I haz the power, 2017-02-28 09:54:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-28 10:16:55]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-02-28 10:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2724573002/#ps100001
(title: "Remove duplicate v8 include")

[commit-bot: I haz the power, 2017-02-28 10:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 11:57:05]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488277015746850,
"parent_rev": "a55b26897fcad47e5d9d7353f24f5cb1f130df65", "commit_rev":
"1ffffb4de5e00f7cf4d45bb051715892ab621d18"}

[commit-bot: I haz the power, 2017-02-28 11:57:49]

Description was changed from

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context
path, move the logic down into LocalWindowProxy/RemoteWindowProxy.
A followup CL will switch RemoteWindowProxy to use v8's remote
context API.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prepare WindowProxy for using v8::Context::NewRemoteContext().

Currently, there is a lot of logic specific to v8::Context in
WindowProxy. Since it won't be used at all for the remote context
path, move the logic down into LocalWindowProxy/RemoteWindowProxy.
A followup CL will switch RemoteWindowProxy to use v8's remote
context API.

BUG=527190
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2724573002
Cr-Commit-Position: refs/heads/master@{#453572}
Committed:
https://chromium.googlesource.com/chromium/src/+/1ffffb4de5e00f7cf4d45bb05171...
==========

[commit-bot: I haz the power, 2017-02-28 11:57:50]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1ffffb4de5e00f7cf4d45bb05171...

[dcheng, 2017-03-06 23:31:08]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2732153002/ by dcheng@chromium.org.

The reason for reverting is: This is causing mysterious crashes. See
https://crbug.com/696528.