Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2731403002: Add a class alias in SessionWindowUnarchiver. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a class alias in SessionWindowUnarchiver. CL https://codereview.chromium.org/2687353003 renamed the class CRWNavigationManagerStorage to CRWSessionStorage but didn't add the mapping to SessionWindowUnarchiver causing the restoration of saved session in branch 3005 to fail in later branches. BUG=698750 Review-Url: https://codereview.chromium.org/2731403002 Cr-Commit-Position: refs/heads/master@{#455000} Committed: https://chromium.googlesource.com/chromium/src/+/8fb2aaae1f672153aac52e747c67a7c181dcc0a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/sessions/session_service.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-03-06 22:13:50 UTC) #5
kkhorimoto
lgtm
3 years, 9 months ago (2017-03-06 23:35:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731403002/1
3 years, 9 months ago (2017-03-06 23:36:00 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 23:42:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fb2aaae1f672153aac52e747c67...

Powered by Google App Engine
This is Rietveld 408576698